Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(371)

Issue 139830043: Added kUnboundedSize to SizeLimitedQuarantine (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by peterssen
Modified:
6 years, 8 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Added kUnboundedSize (~0) to specify unlimited capacity instead of using 0. Trimming a quarantine with max size 0 should flush it. BUG= R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2287

Patch Set 1 #

Total comments: 1

Patch Set 2 : Post-review fixes #

Total comments: 2

Patch Set 3 : Fixed constant name in comments #

Patch Set 4 : Fixed unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M syzygy/agent/asan/quarantines/sharded_quarantine_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M syzygy/agent/asan/quarantines/size_limited_quarantine.h View 1 2 3 chunks +14 lines, -8 lines 0 comments Download
M syzygy/agent/asan/quarantines/size_limited_quarantine_impl.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M syzygy/agent/asan/quarantines/size_limited_quarantine_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
peterssen
PTAL. I'll cleanup existing code (BlockHeapManager) later.
6 years, 8 months ago (2014-08-28 21:28:28 UTC) #1
chrisha
Nice! https://codereview.appspot.com/139830043/diff/1/syzygy/agent/asan/quarantines/size_limited_quarantine.h File syzygy/agent/asan/quarantines/size_limited_quarantine.h (right): https://codereview.appspot.com/139830043/diff/1/syzygy/agent/asan/quarantines/size_limited_quarantine.h#newcode54 syzygy/agent/asan/quarantines/size_limited_quarantine.h:54: static const size_t UNBOUNDED_MAX_SIZE = ~0; More often ...
6 years, 8 months ago (2014-08-29 13:17:23 UTC) #2
peterssen
PTAL. Now kUnboundedSize can be use for max_object_size too.
6 years, 8 months ago (2014-08-29 17:07:50 UTC) #3
chrisha
lgtm with nits https://codereview.appspot.com/139830043/diff/20001/syzygy/agent/asan/quarantines/size_limited_quarantine.h File syzygy/agent/asan/quarantines/size_limited_quarantine.h (right): https://codereview.appspot.com/139830043/diff/20001/syzygy/agent/asan/quarantines/size_limited_quarantine.h#newcode83 syzygy/agent/asan/quarantines/size_limited_quarantine.h:83: // quarantine. Use UNBOUNDED_MAX_SIZE for unlimited ...
6 years, 8 months ago (2014-08-29 17:37:29 UTC) #4
peterssen
6 years, 8 months ago (2014-08-29 19:12:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 2287 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b