Issue 13973043: Support the Windows 8 SDK version of FXC by default in generate_shaders.bat.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13973043: Support the Windows 8 SDK version of FXC by default in generate_shaders.bat. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Jamie Madill

Modified:
10 years, 6 months ago

Reviewers:
Geoff Lang, Shannon Woods, Alok Priyadarshi

CC:
angleproject-review_googlegroups.com, Zhenyao Mo

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Support the Windows 8 SDK version of FXC by default in generate_shaders.bat. Also update the compiled shaders to the new FXC. BUG= ANGLEBUG=475 R=geofflang@chromium.org, shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=384c0cd

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+246 lines, -277 lines)			Patch
M	src/libGLESv2/renderer/shaders/compiled/clear11vs.h	View	4 chunks	+19 lines, -21 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/clearmultiple11ps.h	View	4 chunks	+25 lines, -28 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/clearsingle11ps.h	View	4 chunks	+18 lines, -21 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/componentmaskps.h	View	3 chunks	+21 lines, -23 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/flipyvs.h	View	3 chunks	+19 lines, -21 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/luminanceps.h	View	3 chunks	+21 lines, -22 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/passthrough11vs.h	View	4 chunks	+19 lines, -22 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/passthroughlum11ps.h	View	5 chunks	+17 lines, -20 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/passthroughlumalpha11ps.h	View	5 chunks	+17 lines, -20 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/passthroughps.h	View	3 chunks	+16 lines, -17 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/passthroughrgb11ps.h	View	5 chunks	+17 lines, -20 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/passthroughrgba11ps.h	View	5 chunks	+17 lines, -20 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/compiled/standardvs.h	View	3 chunks	+19 lines, -21 lines	0 comments	Download
M	src/libGLESv2/renderer/shaders/generate_shaders.bat	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Shannon Woods

LGTM. (This is a merge of changes already in es3proto)

10 years, 7 months ago (2013-09-26 21:15:47 UTC) #1

Jamie Madill

10 years, 6 months ago (2013-10-01 14:34:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r384c0cd (presubmit successful).

Expand All Messages | Collapse All Messages