api/provisioner: Addresses/CACert methods added

api/provisioner: Addresses/CACert methods added

Like the deployer API, the provisioner API also
needs to provider StateAddresses(), APIAddresses(),
and CACert(), so we can use the up-to-date (not
localhost) addresses in NewAPIAuthenticator().

This is needed, because the addresses we get
from agent config are incorrect (use localhost),
and without this CL neither containers nor
machines can't connect to state/API server
at provisioning.

And because the same code is already in deployer,
I followed a suggestion to factor it out into
apiserver/common/addresses.

https://code.launchpad.net/~dimitern/juju-core/146-apiprovisioner-addresses/+merge/187719

(do not edit description out of merge proposal)

[dimitern, 2013-09-26 10:56:23]

Please take a look.

[fwereade, 2013-09-26 11:48:25]

If the copy/paste is necessary to get this in time for 1.15, LGTM with an
immediate followup to deduplicate. Much rather see it in this branch though.

[dimitern, 2013-09-26 13:23:11]

Please take a look.

[fwereade, 2013-09-26 13:28:35]

LGTM, thanks.

https://codereview.appspot.com/13963043/diff/6001/state/apiserver/common/addr...
File state/apiserver/common/addresses.go (right):

https://codereview.appspot.com/13963043/diff/6001/state/apiserver/common/addr...
state/apiserver/common/addresses.go:21: // PasswordChanger implements a common
set of methods for getting
PasswordChanger? ;p

https://codereview.appspot.com/13963043/diff/6001/state/apiserver/common/addr...
state/apiserver/common/addresses.go:22: // state and API addresses, as well as
the CA certificated, used to
"state and API server addresses, and the CA certificate used to authenticate
them."?

[dimitern, 2013-09-26 13:42:58]

Please take a look.

https://codereview.appspot.com/13963043/diff/6001/state/apiserver/common/addr...
File state/apiserver/common/addresses.go (right):

https://codereview.appspot.com/13963043/diff/6001/state/apiserver/common/addr...
state/apiserver/common/addresses.go:21: // PasswordChanger implements a common
set of methods for getting
On 2013/09/26 13:28:35, fwereade wrote:
> PasswordChanger? ;p

oops :) Fixed.

https://codereview.appspot.com/13963043/diff/6001/state/apiserver/common/addr...
state/apiserver/common/addresses.go:22: // state and API addresses, as well as
the CA certificated, used to
On 2013/09/26 13:28:35, fwereade wrote:
> "state and API server addresses, and the CA certificate used to authenticate
> them."?

Done.