Add OIDs to certificate-transparency

Add OIDs to certificate-transparency

[ekasper, 2013-09-26 10:40:39]

LGTM

(This stands for: Looks Good To Me, i.e., no changes requested, the patch is
ready for commit.)

To accept the patch, we ask every contributor to grant us the right to use their
contributions. The form for individual contributors can simply be filled in
online:

https://developers.google.com/open-source/cla/individual

(Corporate version here:
https://developers.google.com/open-source/cla/corporate).

If you could ping this thread when you've done this (sorry for the hassle!),
then I'll pick up the patch and commit with you as author.

Thanks,
Emilia

[nickg_client9.com, 2013-09-26 11:00:18]

Form is submitted.  Not a problem at all.

It's under "Nicholas Galbreath"

I have working (but needs tests):

* parsing of authority_info_access (which contains OSCP, etc)
* exposing of cert version in Certficate API (minor, trivial)

I'll probably hack on some of other parsers for extensions.  

Unless you have these already done, in which case I'll wait ;-)

thanks!


nickg

On 2013/09/26, at 19:40, ekasper@google.com wrote:

> LGTM
> 
> (This stands for: Looks Good To Me, i.e., no changes requested, the
> patch is ready for commit.)
> 
> To accept the patch, we ask every contributor to grant us the right to
> use their contributions. The form for individual contributors can simply
> be filled in online:
> 
> https://developers.google.com/open-source/cla/individual
> 
> (Corporate version here:
> https://developers.google.com/open-source/cla/corporate).
> 
> If you could ping this thread when you've done this (sorry for the
> hassle!), then I'll pick up the patch and commit with you as author.
> 
> Thanks,
> Emilia
> 
> https://codereview.appspot.com/13953043/

[ekasper, 2013-09-26 11:07:53]

On Thu, Sep 26, 2013 at 1:00 PM, nickg <nickg@client9.com> wrote:

> Form is submitted.  Not a problem at all.
>
> It's under "Nicholas Galbreath"
>

Yup, I see it. Which email do you prefer listed in the commit?


> I have working (but needs tests):
>
> * parsing of authority_info_access (which contains OSCP, etc)
>

Cool, that's useful.


> * exposing of cert version in Certficate API (minor, trivial)
>

I added this at some point:
https://code.google.com/p/certificate-transparency/source/browse/src/python/c...

Do a git pull?


>
> I'll probably hack on some of other parsers for extensions.
>
> Unless you have these already done, in which case I'll wait ;-)
>

No, go ahead! Probably good to give me a heads-up if you take up a bigger
chunk so that we don't overlap.

Cheers,
Emilia


> thanks!
>
>
> nickg
>
> On 2013/09/26, at 19:40, ekasper@google.com wrote:
>
> > LGTM
> >
> > (This stands for: Looks Good To Me, i.e., no changes requested, the
> > patch is ready for commit.)
> >
> > To accept the patch, we ask every contributor to grant us the right to
> > use their contributions. The form for individual contributors can simply
> > be filled in online:
> >
> > https://developers.google.com/open-source/cla/individual
> >
> > (Corporate version here:
> > https://developers.google.com/open-source/cla/corporate).
> >
> > If you could ping this thread when you've done this (sorry for the
> > hassle!), then I'll pick up the patch and commit with you as author.
> >
> > Thanks,
> > Emilia
> >
> > https://codereview.appspot.com/13953043/
>
>

[nickg_client9.com, 2013-09-26 11:16:29]

re: email
nickg@client9.com is best.

re: auth_info_access

great.. I'll work on tests

re: version
weird.. I must have done a checkout right before then ;-)

re: next

right now I'm just looking at parsing, and haven't completely groked CT in
practice (i get the theory, but..).

If I decide to do something more significant, I'll send a note.

thanks guys!

nickg



On 2013/09/26, at 20:07, Emilia Kasper <ekasper@google.com> wrote:

> 
> 
> 
> On Thu, Sep 26, 2013 at 1:00 PM, nickg <nickg@client9.com> wrote:
> Form is submitted.  Not a problem at all.
> 
> It's under "Nicholas Galbreath"
> 
> Yup, I see it. Which email do you prefer listed in the commit?
> 
> 
> I have working (but needs tests):
> 
> * parsing of authority_info_access (which contains OSCP, etc)
> 
> Cool, that's useful.
>  
> * exposing of cert version in Certficate API (minor, trivial)
> 
> I added this at some point:
>
https://code.google.com/p/certificate-transparency/source/browse/src/python/c...
> 
> Do a git pull?
>  
> 
> I'll probably hack on some of other parsers for extensions.
> 
> Unless you have these already done, in which case I'll wait ;-)
> 
> No, go ahead! Probably good to give me a heads-up if you take up a bigger
chunk so that we don't overlap.
> 
> Cheers,
> Emilia
> 
> 
> thanks!
> 
> 
> nickg
> 
> On 2013/09/26, at 19:40, ekasper@google.com wrote:
> 
> > LGTM
> >
> > (This stands for: Looks Good To Me, i.e., no changes requested, the
> > patch is ready for commit.)
> >
> > To accept the patch, we ask every contributor to grant us the right to
> > use their contributions. The form for individual contributors can simply
> > be filled in online:
> >
> > https://developers.google.com/open-source/cla/individual
> >
> > (Corporate version here:
> > https://developers.google.com/open-source/cla/corporate).
> >
> > If you could ping this thread when you've done this (sorry for the
> > hassle!), then I'll pick up the patch and commit with you as author.
> >
> > Thanks,
> > Emilia
> >
> > https://codereview.appspot.com/13953043/
> 
>