Hook up tools mirrors

Hook up tools mirrors

When finding tools metadata, simplestreams mirrors
are now used. The initial mirrors work was done in
isolation and so it turned out that a chunk of
code could be deleted, since mirrors metadata parsing
is not done stand alone, but incorprated into the
index loading process.

https://code.launchpad.net/~wallyworld/juju-core/use-simplestreams-mirrors/+merge/187642

(do not edit description out of merge proposal)

[wallyworld, 2013-09-26 03:01:18]

Please take a look.

[thumper, 2013-09-26 03:31:39]

LGTM - although not sure I fully grok it.

There are a few places where you have comments that need to be fixed.

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams.go (right):

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams.go:20: //	"path"
wat?

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams.go:607: return mirrorRef.hasCloud(cloud)
//&& mirrorRef.DataType == datatype
why have you commented this out?  the comment above suggests that it is needed.

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams_test.go (right):

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams_test.go:394: if !c.Check(err, gc.IsNil) {
I did not realise that Check had a return type

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/testing...
File environs/simplestreams/testing/testing.go (right):

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/testing...
environs/simplestreams/testing/testing.go:86: "region": "us-east-1",
this indentation looks wrong.  Even though this is JSON, it is hard to follow
the indentation.

[wallyworld, 2013-09-26 03:48:31]

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams.go (right):

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams.go:20: //	"path"
On 2013/09/26 03:31:39, thumper wrote:
> wat?

Sigh. I mean to delete this line

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams.go:607: return mirrorRef.hasCloud(cloud)
//&& mirrorRef.DataType == datatype
On 2013/09/26 03:31:39, thumper wrote:
> why have you commented this out?  the comment above suggests that it is
needed.

Ooops. I meant to uncomment this

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams_test.go (right):

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams_test.go:394: if !c.Check(err, gc.IsNil) {
On 2013/09/26 03:31:39, thumper wrote:
> I did not realise that Check had a return type

Pretty nifty for using in a for loop.

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/testing...
File environs/simplestreams/testing/testing.go (right):

https://codereview.appspot.com/13952043/diff/1/environs/simplestreams/testing...
environs/simplestreams/testing/testing.go:86: "region": "us-east-1",
On 2013/09/26 03:31:39, thumper wrote:
> this indentation looks wrong.  Even though this is JSON, it is hard to follow
> the indentation.

Tabs vs spaces. WFT does Go use tabs I'll never understand.