Close inspector when service is destroyed

app/models/models.js

 /*
 This file is part of the Juju GUI, which lets users view and manage Juju
 environments within a graphical interface (https://launchpad.net/juju-gui).
 Copyright (C) 2012-2013 Canonical Ltd.
 
 This program is free software: you can redistribute it and/or modify it under
 the terms of the GNU Affero General Public License version 3, as published by
 the Free Software Foundation.
 
 This program is distributed in the hope that it will be useful, but WITHOUT
@@ skipping 60 matching lines @@
             instance[key] = value;
           });
           // Lazy model lists don't fire change events
           list.fire('change');
         }
       }
     }
     else if (action === 'remove') {
       if (exists) {
         list.remove(instance);
+        if (list.name === 'serviceList') {
+          instance.destroy();

[jeff.pihach, 2013/09/27 19:19:25]

Whenever we remove a service from a list we now destroy it, application wide -
this is so that anything which relies on that service knows when juju says it
doesn't exist anymore.

[gary.poster, 2013/09/27 19:46:37]

Cool.  This sounds like it is worth a comment in the code itself, if you are
willing.

[jeff.pihach, 2013/09/27 20:13:39]

Done.

+        }
       }
     } else {
       console.warn('Unknown change kind in _process_delta:', action);
     }
     return instance;
   };
 
   /**
     Utility method to return the services involved in the delta.
 
@@ skipping 282 matching lines @@
         @type {string}
       */
       upgrade_to: {},
       aggregated_status: {},
       /**
         The original name from the Charm
 
         @attribute packageName
         @type {String}
       */
-      packageName: {}
+      packageName: {
+        'getter': function(value) {
+          if (value) {
+            return value;
+          } else {
+            // Because the packageName is not set if the
+            // model was created from the core delta.
+            var charm = this.get('charm');
+            // If there is no charm as well, well you have bigger problems :)
+            // but this helps so that we don't need to provide charm data
+            // for every test suite.
+            if (charm) {
+              charm = charm.split('/');
+              charm = charm[charm.length - 1].split('-')[0];
+            }
+            return charm || undefined;
+          }
+        }
+      }
     }
   });
   models.Service = Service;
 
   var ServiceList = Y.Base.create('serviceList', Y.ModelList, [], {
     model: Service,
 
     /**
       Return a list of visible model instances.
 
@@ skipping 129 matching lines @@
       // someone else watching the GUI as a service's charm changes, differ in
       // the amount of information the GUI has originally.  By setting this
       // flag, both cases can react in the same way.
       if (flags.upgradeCharm && oldModelCharm &&
           oldModelCharm !== instance.charmUrl && !service.get('charmChanged')) {
         service.set('charmChanged', true);
       }
       // Some tests add units without creating a service so we need to check
       // for a valid service here.
       if (service) {
-        _process_delta(service.get('units'), action, data, {});
+        var units = service.get('units');
+        _process_delta(units, action, data, {});
+        units.fire('deltaChange', { service: service });

[jeff.pihach, 2013/09/27 19:19:25]

Because units are POJO's they don't fire change events so we need to fire one
manually 

[gary.poster, 2013/09/27 19:46:37]

Nice! we could include the units themselves too, or just their identifiers? 
Maybe for later.

[jeff.pihach, 2013/09/27 20:13:39]

I was thinking about that, but they are readily available to anything which can
listen for this event where not necessarily for the service.

       } else {
         // fixTests
         console.error('Units added without matching Service');
       }
     },
 
     _setDefaultsAndCalculatedValues: function(obj) {
       var raw = obj.id.split('/');
       obj.service = raw[0];
       obj.number = parseInt(raw[1], 10);
@@ skipping 648 matching lines @@
     'datasource-jsonschema',
     'io-base',
     'json-parse',
     'juju-delta-handlers',
     'juju-endpoints',
     'juju-view-utils',
     'juju-charm-models',
     'promise'
   ]
 });