Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2445)

Issue 13916043: environs: EnvironProvider.SecretAttrs() strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dimitern
Modified:
10 years, 7 months ago
Reviewers:
mp+187566, fwereade
Visibility:
Public.

Description

environs: EnvironProvider.SecretAttrs() strings Changed EnvironProvider.SecretAttrs() method to return map[string]string, instead of map[string]interface{}, as this is a prerequisite step to pluging in the security issue we have with the provisioner API. Also, because all providers currently use string values as secret attributes, this causes no further stir. https://code.launchpad.net/~dimitern/juju-core/144-environs-secretattrs-strings/+merge/187566 Requires: https://code.launchpad.net/~dimitern/juju-core/144-worker-provisioner-uses-api/+merge/187191 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: EnvironProvider.SecretAttrs() strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/interface.go View 1 1 chunk +3 lines, -2 lines 0 comments Download
M juju/conn.go View 1 chunk +4 lines, -2 lines 0 comments Download
M provider/azure/config.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/azure/config_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/dummy/config_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M provider/dummy/environs.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M provider/ec2/config_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/ec2.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M provider/local/environprovider.go View 1 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/environprovider.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/maas/environprovider_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/config_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/provider.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
dimitern
Please take a look.
10 years, 7 months ago (2013-09-25 17:08:53 UTC) #1
dimitern
Please take a look.
10 years, 7 months ago (2013-09-25 17:50:01 UTC) #2
fwereade
10 years, 7 months ago (2013-09-25 17:56:53 UTC) #3
Excellent, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b