Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(547)

Issue 138880043: Remove the unguarded allocation heap. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by Sébastien Marchand
Modified:
6 years, 8 months ago
Reviewers:
chrisha
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove the unguarded allocation heap. This isn't really needed and it adds some useless complexity to the block heap manager. BUG= R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M syzygy/agent/asan/heap_managers/block_heap_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M syzygy/agent/asan/heap_managers/block_heap_manager.cc View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Sébastien Marchand
PTAL.
6 years, 8 months ago (2014-08-29 15:16:49 UTC) #1
chrisha
lgtm!
6 years, 8 months ago (2014-08-29 15:44:34 UTC) #2
Sébastien Marchand
6 years, 8 months ago (2014-08-29 15:49:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2284 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b