Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3975)

Issue 13850043: Combine translator_common, translator_hlsl, translator_glsl into one target translator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Zhenyao Mo
Modified:
10 years, 7 months ago
CC:
angleproject-review_googlegroups.com, kbr1, apatrick1, Shannon Woods, VangelisK
Base URL:
https://code.google.com/p/angleproject/@master
Visibility:
Public.

Description

Combine translator_common, translator_hlsl, translator_glsl into one target translator. Because right now webkit is depending on translator_glsl, so we will create a duplication of translator as translator_glsl, which will be removed once we fix the webkit side. BUG= R=shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=3662294

Patch Set 1 : #

Total comments: 2

Patch Set 2 : simplify translator_glsl to reference translator_static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -128 lines) Patch
M src/build_angle.gypi View 1 8 chunks +36 lines, -58 lines 0 comments Download
A + src/compiler/CodeGen.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
D src/compiler/CodeGenGLSL.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
D src/compiler/CodeGenHLSL.cpp View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6
Zhenyao Mo
Alok, please review. Others, FYI.
10 years, 7 months ago (2013-09-23 23:45:44 UTC) #1
Alok Priyadarshi
+shannon You would need to update the visual-studio projects as well. https://codereview.appspot.com/13850043/diff/5001/src/build_angle.gypi File src/build_angle.gypi (right): ...
10 years, 7 months ago (2013-09-24 00:05:29 UTC) #2
Zhenyao Mo
Right, I forgot about the win project file. If it's OK, I'd like to land ...
10 years, 7 months ago (2013-09-24 00:18:35 UTC) #3
Shannon Woods
LGTM, with the caveat that I'm not overly familiar with gyp setup. Geoff's working on ...
10 years, 7 months ago (2013-09-24 19:20:22 UTC) #4
Zhenyao Mo
On 2013/09/24 19:20:22, Shannon Woods wrote: > LGTM, with the caveat that I'm not overly ...
10 years, 7 months ago (2013-09-24 20:20:34 UTC) #5
Zhenyao Mo
10 years, 7 months ago (2013-09-24 20:23:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r3662294 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b