Issue 13831043: Rewrite profiling_view to speak XHR-based to tracing_ui.cc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13831043: Rewrite profiling_view to speak XHR-based to tracing_ui.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by nduca

Modified:
11 years, 8 months ago

Reviewers:
johnjbarton

CC:
trace-viewer-review_googlegroups.com

Base URL:
http://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Rewrite profiling_view to speak XHR-based to tracing_ui.cc This removes tracing_controller entirely. XHR is used to talk to tracing_ui. Save and load are implemented as pure HTML5 features. BUG=420

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : . #

Patch Set 5 : Make it work #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+933 lines, -884 lines)			Patch
M	examples/trace_viewer.html	View		3 chunks	+13 lines, -7 lines	0 comments	Download
M	src/about_tracing.html.template	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/about_tracing.js.template	View		1 chunk	+1 line, -6 lines	0 comments	Download
A	src/about_tracing/begin_recording.js	View	1 2 3	1 chunk	+142 lines, -0 lines	0 comments	Download
A	src/about_tracing/begin_recording_test.js	View	1 2 3	1 chunk	+56 lines, -0 lines	0 comments	Download
A	src/about_tracing/mock_request_handler.js	View	1 2 3	1 chunk	+63 lines, -0 lines	0 comments	Download
D	src/about_tracing/profiling_view.css	View		1 chunk	+0 lines, -20 lines	0 comments	Download
A	src/about_tracing/profiling_view.html	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/about_tracing/profiling_view.js	View	1	4 chunks	+179 lines, -271 lines	0 comments	Download
M	src/about_tracing/profiling_view_test.js	View	1 2 3	1 chunk	+35 lines, -379 lines	0 comments	Download
A	src/base/array_buffer_utils.js	View	1 2 3 4	1 chunk	+50 lines, -0 lines	0 comments	Download
M	src/base/unittest/assertions.js	View	1 2 3	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/tracing/importer/task.js	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/tracing/importer/trace_event_importer.js	View	1 2 3	3 chunks	+10 lines, -0 lines	0 comments	Download
M	src/tracing/importer/trace_event_importer_test.js	View	1 2 3	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/tracing/record_selection_dialog.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/tracing/timeline_view.css	View	1	1 chunk	+183 lines, -183 lines	0 comments	Download
M	src/tracing/timeline_view.js	View	1 2	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/ui/info_bar.css	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	src/ui/info_bar.js	View		2 chunks	+51 lines, -2 lines	0 comments	Download
M	src/ui/info_bar_test.js	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	src/ui/overlay.js	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	trace_viewer.gyp	View	1 2 3	4 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

johnjbarton

11 years, 11 months ago (2013-09-30 23:50:13 UTC) #1

HTH

https://codereview.appspot.com/13831043/diff/5001/src/about_tracing/begin_rec...
File src/about_tracing/begin_recording_test.js (right):

https://codereview.appspot.com/13831043/diff/5001/src/about_tracing/begin_rec...
src/about_tracing/begin_recording_test.js:18: test('fullRecording', function() {
I think a better style for async test functions is to start another function:

  return new Promise(function(r) {
    // In here we call r.resolve() for success and r.reject for fail

  });

https://codereview.appspot.com/13831043/diff/5001/src/about_tracing/begin_rec...
src/about_tracing/begin_recording_test.js:48: assertEquals(data,
JSON.stringify(testData));
r.resolve();

https://codereview.appspot.com/13831043/diff/5001/src/about_tracing/begin_rec...
src/about_tracing/begin_recording_test.js:51: throw new Error('This should never
be reached');
r.reject('This should never be reached');

Expand All Messages | Collapse All Messages