Issue 13828043: Clean up lxc tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13828043: Clean up lxc tests.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by thumper

Modified:
10 years, 7 months ago

Reviewers:
mp+186951, wallyworld

Visibility:
Public.

Description

Clean up lxc tests. Take advantage of some of the newer testing capabilities to simplify the lxc tests. https://code.launchpad.net/~thumper/juju-core/lxc-test-refactor/+merge/186951 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -84 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/lxc/lxc_test.go	View	2 chunks	+2 lines, -17 lines	0 comments	Download
M	container/lxc/test.go	View	1 chunk	+13 lines, -63 lines	0 comments	Download
M	provider/local/environprovider_test.go	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	worker/provisioner/lxc-broker_test.go	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

wallyworld

10 years, 7 months ago (2013-09-23 00:01:19 UTC) #2

LGTM, but I was very confused by the difference between
testbase.PatchEnvironment and CleaupSuite.PatchEnvironment. I really wish the
method names were not the same.

Expand All Messages | Collapse All Messages