Issue 13826049: fix some eclipse warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13826049: fix some eclipse warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by felix8a

Modified:
12 years, 5 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This is part 1 of an N-part plan to deprecate com.google.util.List and related classes - fix static method used in non-static call. - delete some unused private static methods. - use Json.put instead of JSONObject#put to suppress warnings about unchecked generics. - @SuppressWarnings("resource") unfortunately will cause a warning about unnecessary @SuppressWarnings if you turn off the flag to warn about possible resource leaks. In this case, it's harmless to close.

Patch Set 1 #

Total comments: 3

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -55 lines)			Patch
M	src/com/google/caja/service/AbstractCajolingHandler.java	View	3 chunks	+9 lines, -35 lines	0 comments	Download
M	src/com/google/caja/tools/AbstractCajaAntTask.java	View	2 chunks	+2 lines, -3 lines	3 comments	Download
M	tests/com/google/caja/util/RhinoTestBed.java	View	4 chunks	+1 line, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kpreid2

LGTM++ https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/AbstractCajaAntTask.java File src/com/google/caja/tools/AbstractCajaAntTask.java (right): https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/AbstractCajaAntTask.java#newcode94 src/com/google/caja/tools/AbstractCajaAntTask.java:94: logger.close(); I'm worried that this only works by ...

12 years, 5 months ago (2013-09-24 16:51:20 UTC) #2

felix8a

@r5602 https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/AbstractCajaAntTask.java File src/com/google/caja/tools/AbstractCajaAntTask.java (right): https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/AbstractCajaAntTask.java#newcode94 src/com/google/caja/tools/AbstractCajaAntTask.java:94: logger.close(); On 2013/09/24 16:51:20, kpreid2 wrote: > I'm ...

12 years, 5 months ago (2013-09-24 17:39:57 UTC) #3

kpreid2

12 years, 5 months ago (2013-09-24 17:45:22 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/Abst...
File src/com/google/caja/tools/AbstractCajaAntTask.java (right):

https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/Abst...
src/com/google/caja/tools/AbstractCajaAntTask.java:94: logger.close();
On 2013/09/24 17:39:57, felix8a wrote:
> On 2013/09/24 16:51:20, kpreid2 wrote:
> > I'm worried that this only works by accident. Does Ant's API documentation
> > have something to say about the lifetime of getLogger()?
> 
> it's our getLogger, defined at line 116 below. I'll make it private.

Oh, I see, it's not-really-closeable. Erf.

How about calling the method makeLogger?

Expand All Messages | Collapse All Messages