Issue 13811043: version: there can be only one

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13811043: version: there can be only one

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mp+186861, natefinch

Visibility:
Public.

Description

version: there can be only one Having both version.CurrentSeries and version.Current.Series is a recipe for problems. Fixes https://bugs.launchpad.net/juju-core/+bug/1228315 After this, juju-core should test OK under Saucy. https://code.launchpad.net/~rogpeppe/juju-core/410-only-one-version/+merge/186861 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : version: there can be only one #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -42 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata_test.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/version_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/jujutest/livetests.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/mongo_test.go	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	environs/sync/sync_test.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	environs/tools/validation.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/local/environ.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/local/environprovider.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/openstack/local_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	version/current_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	version/version.go	View	1 chunk	+3 lines, -18 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages