Issue 138010043: Add patchset ID to each message in /api/1234567?messages=true

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138010043: Add patchset ID to each message in /api/1234567?messages=true (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by jrobbins (chromium)

Modified:
10 years, 9 months ago

Reviewers:
sergeyberezin, jrobbins (corp), bozenaujurczak, Sergey Berezin (Google)

Visibility:
Public.

More Reviews

Description

Each Message object records the last patchset at the time that the Message object was created. To implement the stricter check, you will also need to know if the Message patchset == the last patchset on the issue at the time of the CQ submission. BUG=409583

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	codereview/models.py	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	codereview/views.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jrobbins (corp)

Committed as https://code.google.com/p/rietveld/source/detail?r=8808faba6fee6725a285006acd1761cb2e0429c1&name=chromium

11 years ago (2014-09-04 16:32:41 UTC) #3

Message was sent while issue was closed.

Expand All Messages | Collapse All Messages