Issue 13789045: Reorder simplestreams dtaa sources

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13789045: Reorder simplestreams dtaa sources (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by wallyworld

Modified:
10 years, 7 months ago

Reviewers:
fwereade, mp+186800

Visibility:
Public.

Description

Reorder simplestreams dtaa sources The simplestreams data sources were ordered as: config url control bucket keystone endpoint public url However, this prevents devel tools from being found on HP Cloud since the pre-configured tools url metadata hides the devel metadata uploaded to the control bucket. So the new order is: control bucket keystone endpoint config url public url https://code.launchpad.net/~wallyworld/juju-core/simplestreams-sources/+merge/186800 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -20 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/imagemetadata/urls.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	environs/imagemetadata/urls_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/tools/urls.go	View	2 chunks	+6 lines, -3 lines	1 comment	Download
M	environs/tools/urls_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/openstack/local_test.go	View	2 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

10 years, 7 months ago (2013-09-20 14:09:25 UTC) #2

LGTM, just some droppings to clean up.

https://codereview.appspot.com/13789045/diff/1/environs/tools/urls.go
File environs/tools/urls.go (right):

https://codereview.appspot.com/13789045/diff/1/environs/tools/urls.go#newcode33
environs/tools/urls.go:33: //	}
d

Expand All Messages | Collapse All Messages