Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4910)

Issue 13786043: environs/configstore: allow empty info

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
mue, mp+186583, dimitern
Visibility:
Public.

Description

environs/configstore: allow empty info We actually need to be able to read environment info that hasn't been written because otherwise we will never be able to destroy an environment that was interrupted half way through bootstrap. We nonetheless need to know if the environment info was empty so that we can do the right thing when opening an environment that is currently bootstrapping, so we provide the Initialize method to that end. https://code.launchpad.net/~rogpeppe/juju-core/402-configstore-allow-empty/+merge/186583 Requires: https://code.launchpad.net/~rogpeppe/juju-core/397-configstore-write/+merge/186471 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/configstore: allow empty info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/configstore/disk.go View 3 chunks +11 lines, -3 lines 0 comments Download
M environs/configstore/disk_test.go View 4 chunks +5 lines, -2 lines 0 comments Download
M environs/info.go View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 7 months ago (2013-09-19 16:44:18 UTC) #1
mue
LGTM
10 years, 7 months ago (2013-09-19 16:46:51 UTC) #2
dimitern
10 years, 7 months ago (2013-09-19 16:49:15 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b