Issue 137770043: SOCIS2014: Test macros

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 137770043: SOCIS2014: Test macros (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by n.p

Modified:
8 years, 5 months ago

Reviewers:
Peter Barnes, Tom Henderson

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -1 line)			Patch
	M	src/core/model/test.h	View		4 chunks	+93 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Tom Henderson

https://codereview.appspot.com/137770043/diff/1/src/core/model/test.h File src/core/model/test.h (right): https://codereview.appspot.com/137770043/diff/1/src/core/model/test.h#newcode1015 src/core/model/test.h:1015: * \brief Test that an actual value is greater ...

9 years, 8 months ago (2014-08-29 17:30:10 UTC) #1

Peter Barnes

I think there's one erroneous edit on l. 1057. https://codereview.appspot.com/137770043/diff/1/src/core/model/test.h File src/core/model/test.h (right): https://codereview.appspot.com/137770043/diff/1/src/core/model/test.h#newcode1057 src/core/model/test.h:1057: ...

9 years, 7 months ago (2014-09-02 23:58:01 UTC) #2

Tom Henderson

9 years, 3 months ago (2015-01-30 02:46:55 UTC) #3

this patch has been merged in ns-3-dev changeset 10884:78099d73b2f4 Sept 4, 2014

Expand All Messages | Collapse All Messages