Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 1376042: code review 1376042: go spec: change def. of "type compatibility" to be non-... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 4 months ago by gri
Modified:
16 years, 4 months ago
Reviewers:
CC:
rsc, iant, ken2, r, golang-dev
Visibility:
Public.

Description

go spec: change def. of "type compatibility" to be non-recursive and adjust conversion rules. Also: - clarification of type identity (no language change) - adjust special rules for channel assignment/comparison to require identical element types (in correspondence to non- recursiveness of type compatibility)

Patch Set 1 #

Patch Set 2 : code review 1376042: go spec: change def. of "type compatibility" to be non-... #

Patch Set 3 : code review 1376042: go spec: change def. of "type compatibility" to be non-... #

Patch Set 4 : code review 1376042: go spec: change def. of "type compatibility" to be non-... #

Total comments: 3

Patch Set 5 : code review 1376042: go spec: change def. of "type compatibility" to be non-... #

Total comments: 2

Patch Set 6 : code review 1376042: go spec: change def. of "type compatibility" to be non-... #

Patch Set 7 : code review 1376042: go spec: change def. of "type compatibility" to be non-... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 6 13 chunks +38 lines, -28 lines 0 comments Download

Messages

Total messages: 7
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change.
16 years, 4 months ago (2010-05-28 18:22:04 UTC) #1
gri
Hello rsc, iant, ken2, r (cc: golang-dev@googlegroups.com), Please take another look.
16 years, 4 months ago (2010-05-28 18:23:41 UTC) #2
rsc1
LGTM http://codereview.appspot.com/1376042/diff/9001/6002 File doc/go_spec.html (right): http://codereview.appspot.com/1376042/diff/9001/6002#newcode3281 doc/go_spec.html:3281: Such a conversion renames the type but does ...
16 years, 4 months ago (2010-05-28 18:37:13 UTC) #3
gri
Hello rsc, iant, ken2, r (cc: golang-dev@googlegroups.com), Please take another look.
16 years, 4 months ago (2010-05-28 18:45:47 UTC) #4
r
LGTM http://codereview.appspot.com/1376042/diff/14001/1002 File doc/go_spec.html (right): http://codereview.appspot.com/1376042/diff/14001/1002#newcode1253 doc/go_spec.html:1253: Two anonymous fields are considered to have the ...
16 years, 4 months ago (2010-05-28 19:04:21 UTC) #5
iant
LGTM
16 years, 4 months ago (2010-05-28 21:15:27 UTC) #6
gri
16 years, 4 months ago (2010-05-28 21:17:36 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=bfadbd48d3ea ***

go spec: change def. of "type compatibility" to be non-recursive
and adjust conversion rules.

Also:
- clarification of type identity (no language change)
- adjust special rules for channel assignment/comparison to
  require identical element types (in correspondence to non-
  recursiveness of type compatibility)

R=rsc, iant, ken2, r
CC=golang-dev
http://codereview.appspot.com/1376042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b