Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 13720050: various: start implementing ssl-hostname=false

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by jameinel
Modified:
12 years, 3 months ago
Reviewers:
mp+187176, mue
Visibility:
Public.

Description

various: start implementing ssl-hostname=false This is the first step towards allowing people to use self-signed certificates. It isn't a complete fix, as we still have stuff like Upgrader and Uniter accessing the private storage. However, it is a 'ratchet' of stuff that now works (you can bootstrap, etc). The next steps are teaching "cloud-init" to wget with disabled certs, and then Upgrader, Uniter, etc. https://code.launchpad.net/~jameinel/juju-core/ssl-hostname-verify-1202163/+merge/187176 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : various: start implementing ssl-hostname=false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -57 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/plugins/juju-metadata/validateimagemetadata.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-metadata/validatetoolsmetadata.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/imagemetadata/simplestreams_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/imagemetadata/urls.go View 1 2 chunks +8 lines, -3 lines 0 comments Download
M environs/imagemetadata/validation_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/instances/image_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/simplestreams/datasource.go View 1 3 chunks +32 lines, -4 lines 0 comments Download
M environs/simplestreams/datasource_test.go View 3 chunks +53 lines, -2 lines 0 comments Download
M environs/simplestreams/simplestreams.go View 1 chunk +1 line, -0 lines 0 comments Download
M environs/simplestreams/simplestreams_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools/simplestreams_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/tools/testing/testing.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools/tools_test.go View 1 1 chunk +3 lines, -1 line 0 comments Download
M environs/tools/urls.go View 1 2 chunks +8 lines, -3 lines 0 comments Download
M environs/tools/validation_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M provider/azure/environ.go View 1 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/image_test.go View 1 2 chunks +3 lines, -2 lines 0 comments Download
M provider/openstack/config_test.go View 1 3 chunks +38 lines, -18 lines 0 comments Download
M provider/openstack/export_test.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
M provider/openstack/local_test.go View 1 6 chunks +265 lines, -3 lines 0 comments Download
M provider/openstack/provider.go View 1 5 chunks +24 lines, -5 lines 0 comments Download
A utils/http.go View 1 chunk +24 lines, -0 lines 0 comments Download
A utils/http_test.go View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 4
jameinel
Please take a look.
12 years, 3 months ago (2013-09-24 09:42:26 UTC) #1
mue
LGTM, great work. https://codereview.appspot.com/13720050/diff/1/environs/simplestreams/datasource.go File environs/simplestreams/datasource.go (right): https://codereview.appspot.com/13720050/diff/1/environs/simplestreams/datasource.go#newcode30 environs/simplestreams/datasource.go:30: type SSLHostnameVerification bool Even if the ...
12 years, 3 months ago (2013-09-24 14:41:56 UTC) #2
jameinel
Please take a look.
12 years, 3 months ago (2013-09-25 12:43:20 UTC) #3
mue
12 years, 3 months ago (2013-09-25 13:48:08 UTC) #4
On 2013/09/25 12:43:20, jameinel wrote:
> Please take a look.

Thx for the additional comments. The new parts LGTM too. It's now a real big CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b