Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 13717044: A little clean up for initial agent logging.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by thumper
Modified:
11 years, 6 months ago
Reviewers:
wallyworld, mp+185962
Visibility:
Public.

Description

A little clean up for initial agent logging. Now that we have a logging worker that will set the log levels to the system wide setting when it starts, we can start all new agents with debug, and then as soon as the agent starts, it will change it. A drive by fix here to have the machine agent explicitly remove the logfile writer from loggo if one has been set. Machine agent upstart jobs that are around from before 1.16 will otherwise cause duplicate lines. https://code.launchpad.net/~thumper/juju-core/logger-initial-state/+merge/185962 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 2 chunks +6 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 4 chunks +5 lines, -11 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M provider/local/environ.go View 1 chunk +1 line, -2 lines 0 comments Download
M upstart/service.go View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
thumper
Please take a look.
11 years, 6 months ago (2013-09-17 02:03:35 UTC) #1
wallyworld
11 years, 6 months ago (2013-09-17 02:15:53 UTC) #2
LGTM, although I'd prefer to see an integration style test that confirms that
debug is used and then turned off as expected. We do this sort of thing
elsewhere for other similar "live" sets of tests.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b