Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 13715044: Remove ghost CSS duplication (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by huwshimi
Modified:
11 years, 6 months ago
Reviewers:
rharding, mp+185731
Visibility:
Public.

Description

Remove ghost CSS duplication Much of the CSS required for the inspector layout was duplicated for the ghost inspector, even though the presentation is the same. The result of this branch should be that the ghost inspector looks exactly the same, but now with less code and less duplication and fragmentation for future updates. https://code.launchpad.net/~huwshimi/juju-gui/ghost-style-merge/+merge/185731 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -173 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/ghost-config-viewlet.handlebars View 1 chunk +40 lines, -47 lines 0 comments Download
M app/templates/service-configuration.handlebars View 1 chunk +8 lines, -6 lines 0 comments Download
M app/templates/service-constraints-viewlet.handlebars View 1 chunk +6 lines, -4 lines 0 comments Download
M app/templates/service-relations-list.handlebars View 1 chunk +3 lines, -1 line 0 comments Download
M app/views/ghost-inspector.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/juju-inspector.less View 12 chunks +50 lines, -110 lines 1 comment Download
M lib/views/stylesheet.less View 1 chunk +21 lines, -0 lines 0 comments Download
M test/test_ghost_inspector.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
huwshimi
Please take a look.
11 years, 6 months ago (2013-09-16 08:43:10 UTC) #1
rharding
LGTM IE10 QA ok. https://codereview.appspot.com/13715044/diff/1/lib/views/juju-inspector.less File lib/views/juju-inspector.less (right): https://codereview.appspot.com/13715044/diff/1/lib/views/juju-inspector.less#newcode686 lib/views/juju-inspector.less:686: .view-content { I noticed this ...
11 years, 6 months ago (2013-09-16 11:39:34 UTC) #2
huwshimi
11 years, 6 months ago (2013-09-16 23:46:46 UTC) #3
On 2013/09/16 11:39:34, rharding wrote:
> LGTM IE10 QA ok.
> 
> https://codereview.appspot.com/13715044/diff/1/lib/views/juju-inspector.less
> File lib/views/juju-inspector.less (right):
> 
>
https://codereview.appspot.com/13715044/diff/1/lib/views/juju-inspector.less#...
> lib/views/juju-inspector.less:686: .view-content {
> I noticed this is used a lot more but it's not clear when to use it and when
not
> to. For instance, in the relations template, it's used when there are no
> relations, but not when there are some. view-content seems ambiguous. Is there
a
> better name for this perhaps?

You're correct, the current name implies there might only be one but it's become
a content block and could be named more helpfully.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b