DescriptionOlder Message entities in the datastore have no value for auto_generated, so they will not match a query for either auto_generated == True or a query for auto_generated == False. To get the ones that are not auto_generated, you have to do auto_generated != True. To complicate things a bit, using != is restricted in GAE datastore queries to be only on one property and only the same as any sort directive. So, for approvals/disapprovals, I did post-filtering.
The reviewer_approval field is computed and then stored, so there will be some CLs that have the all black and no green/red links displayed until each of those CLs gets another comment added after this fix is deployed.
Also, I checked https://groups.google.com/a/chromium.org/forum/#!forum/chromium-reviews and it looks like we sent out some extra diffs today, but I don't think anyone will really care, especially because duplicates are displayed collapsed in gmail and google groups.
Patch Set 1 #
Total comments: 1
MessagesTotal messages: 4
|