Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(631)

Issue 137090043: Make queries for auto_generated work with older CLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by jrobbins (chromium)
Modified:
11 years ago
Visibility:
Public.

Description

Older Message entities in the datastore have no value for auto_generated, so they will not match a query for either auto_generated == True or a query for auto_generated == False. To get the ones that are not auto_generated, you have to do auto_generated != True. To complicate things a bit, using != is restricted in GAE datastore queries to be only on one property and only the same as any sort directive. So, for approvals/disapprovals, I did post-filtering. The reviewer_approval field is computed and then stored, so there will be some CLs that have the all black and no green/red links displayed until each of those CLs gets another comment added after this fix is deployed. Also, I checked https://groups.google.com/a/chromium.org/forum/#!forum/chromium-reviews and it looks like we sent out some extra diffs today, but I don't think anyone will really care, especially because duplicates are displayed collapsed in gmail and google groups.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M codereview/models.py View 1 chunk +6 lines, -1 line 1 comment Download
M codereview/views.py View 1 chunk +1 line, -1 line 0 comments Download
M index.yaml View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4
jrobbins (chromium)
11 years ago (2014-09-03 02:20:54 UTC) #1
jrobbins (corp)
The index.yaml change is just an automatic change resulting from when I ran the app ...
11 years ago (2014-09-03 02:22:21 UTC) #2
rmistry
LGTM Thanks for the quick fix! Let me know when it is staged, I will ...
11 years ago (2014-09-03 11:29:54 UTC) #3
jrobbins (corp)
11 years ago (2014-09-03 13:56:43 UTC) #4
Committed and deployed for testing at
https://1433-109a53420dcd-dot-chromiumcodereview-hr.appspot.com/


On Wed, Sep 3, 2014 at 4:29 AM, <rmistry@google.com> wrote:

> LGTM
>
> Thanks for the quick fix!
> Let me know when it is staged, I will help test it.
>
>
> https://codereview.appspot.com/137090043/diff/1/codereview/models.py
> File codereview/models.py (right):
>
> https://codereview.appspot.com/137090043/diff/1/codereview/models.py#
> newcode281
> codereview/models.py:281: # and (b) auto_generated != False conflicts
> with sorting.
> I think you meant to invert the booleans in this comment:
>
> (a) auto_generated == False does not return legacy messages
> (b) auto_generated != True conflicts with sorting
>
> https://codereview.appspot.com/137090043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b