BUILTIN group handling for AD adaptor

BUILTIN group handling for AD adaptor

Code Commit : https://code.google.com/p/plexi/source/detail?r=76af3f50d5c1961f6d2e9de726b341d63cf34e79&repo=ad

[Tanmay Vartak, 2013-09-13 23:13:06]

On 2013/09/13 23:10:19, Tanmay Vartak wrote:

BUILTIN Support
1. Change domain for BUILTIN groups to "BUILTIN"
2. By default don't feed BUILTIN groups

[ejona, 2013-09-14 00:40:24]

https://codereview.appspot.com/13701045/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/ad/AdAdaptor.java (right):

https://codereview.appspot.com/13701045/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/ad/AdAdaptor.java:46: private boolean
feedBuiltinGroups = false;
Don't set it to 'false' here. Not only is that the default, but it doesn't have
any effect because it is overridden in init(), so it is a bit misleading (that
is has an effect).

https://codereview.appspot.com/13701045/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/ad/AdAdaptor.java:298: if(!feedBuiltinGroups
Hmm... If we feed builtin groups and then you turn it off again, all the builtin
groups will still be there. Should we sent empty built-in groups when feeding
them is disabled?

[ejona, 2013-09-17 21:10:33]

LGTM