Issue 136950043: [observe-js] prevent incorrect codegen with empty path string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 136950043: [observe-js] prevent incorrect codegen with empty path string (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by John Messerly

Modified:
9 years, 7 months ago

Reviewers:
arv, rafaelw1, rafaelw

Base URL:
ssh://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

prevent incorrect codegen with empty path string fixes https://github.com/Polymer/polymer-expressions/issues/42 investigation notes here: https://github.com/Polymer/polymer-expressions/issues/42#issuecomment-53829454 it didn't look to me like isIndex was called on a hot path, so I just added a guard against empty string. Let me know if there's a smarter way to do that check. R=rafaelw@chromium.org Committed: https://github.com/Polymer/observe-js/commit/9552ec3