Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 13694048: Validate severity name passed to ses.ok. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by kpreid2
Modified:
12 years, 5 months ago
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Previously, ses.ok('not a valid name') was treated as equivalent to ses.ok(), which is dangerous if, for example, the maxAcceptableSeverity is set high and the intent of the ses.ok(...) call was to make a choice based on meeting a lower severity (as caja.js does). Now, passing an unknown severity name will throw an error. Fixes <https://code.google.com/p/google-caja/issues/detail?id=1758>. Supporting changes: * browser-test-case.html no longer requires an es5= parameter, but will fail if anything which would depend on it is called while it is unspecified. This allows it to be used for tests that do not use caja.js at all, such as this new test for SES. * Tweaked ses-tests.json catalog to use inheritance/grouping. * Note: severityNameToLevel was misnamed and entirely unused. @r5603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -70 lines) Patch
M src/com/google/caja/ses/repairES5.js View 3 chunks +8 lines, -7 lines 0 comments Download
M tests/com/google/caja/plugin/browser-test-case.js View 4 chunks +11 lines, -5 lines 0 comments Download
M tests/com/google/caja/ses/ses-tests.json View 1 chunk +56 lines, -58 lines 0 comments Download
A tests/com/google/caja/ses/test-ses-parts.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kpreid2
12 years, 5 months ago (2013-09-23 20:42:07 UTC) #1
MarkM
repairES5.js LGTM
12 years, 5 months ago (2013-09-24 02:07:39 UTC) #2
kpreid2
On 2013/09/24 02:07:39, MarkM wrote: > repairES5.js LGTM I assume you want me to find ...
12 years, 5 months ago (2013-09-24 02:09:36 UTC) #3
Mark S. Miller
Sorry, yes. I no longer have enough context to review the other files. On Mon, ...
12 years, 5 months ago (2013-09-24 02:12:11 UTC) #4
felix8a
12 years, 5 months ago (2013-09-24 02:14:00 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b