Issue 13694047: sync tools ignores legacy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13694047: sync tools ignores legacy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by wallyworld

Modified:
10 years, 7 months ago

Reviewers:
mp+186705, thumper

Visibility:
Public.

Description

sync tools ignores legacy sync tools ignores any legacy tools when it does the syncing. https://code.launchpad.net/~wallyworld/juju-core/synctools-use-new-location/+merge/186705 Requires: https://code.launchpad.net/~wallyworld/juju-core/builtin-hpcloud-support/+merge/186700 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/sync/sync.go	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	environs/sync/sync_test.go	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

LGTM with a comment. https://codereview.appspot.com/13694047/diff/1/environs/sync/sync.go File environs/sync/sync.go (right): https://codereview.appspot.com/13694047/diff/1/environs/sync/sync.go#newcode99 environs/sync/sync.go:99: restore := envtools.SetToolPrefix(envtools.NewToolPrefix) holy crap ...

10 years, 7 months ago (2013-09-20 04:50:06 UTC) #2

wallyworld

10 years, 7 months ago (2013-09-20 04:55:37 UTC) #3

https://codereview.appspot.com/13694047/diff/1/environs/sync/sync.go
File environs/sync/sync.go (right):

https://codereview.appspot.com/13694047/diff/1/environs/sync/sync.go#newcode99
environs/sync/sync.go:99: restore :=
envtools.SetToolPrefix(envtools.NewToolPrefix)
On 2013/09/20 04:50:06, thumper wrote:
> holy crap this method is 80 lines long.
> 
> Can you please add a comment as to why the tools prefix is being changed, and
> why it is being put back again.  It certainly isn't obvious by looking at
these
> few lines of code.

Done.

Expand All Messages | Collapse All Messages