Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 13694046: Add a testbase package with no juju-core deps.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by thumper
Modified:
10 years, 7 months ago
Reviewers:
mp+186701, axw1
Visibility:
Public.

Description

Add a testbase package with no juju-core deps. The base cleanup and logging suites are now there, as are the patch functions. A test also exists there to make sure that no juju-core dependencies creep in. https://code.launchpad.net/~thumper/juju-core/testbase/+merge/186701 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -174 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/format-1.12_whitebox_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/format-1.16_whitebox_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/format_whitebox_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M agent/tools/diskmanager_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M agent/tools/tools_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M charm/dir_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M charm/repo_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M cmd/juju/bootstrap_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/plugin_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/publish_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/synctools_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/jujud/agent_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/jujud/bootstrap_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/jujud/machine_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/logging_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M container/lxc/lxc_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M downloader/downloader_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/bootstrap/bootstrap_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/cert_internal_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/cert_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/cloudinit/cloudinit_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/cloudinit_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/config/config_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/httpstorage/backend_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/imagemetadata/validation_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/instances/image_test.go View 2 chunks +2 lines, -10 lines 0 comments Download
M environs/instances/instancetype_test.go View 1 chunk +2 lines, -10 lines 0 comments Download
M environs/jujutest/livetests.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/jujutest/tests.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/manual/detection_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M environs/mongo_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/simplestreams/testing/testing.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/sshstorage/storage_test.go View 3 chunks +5 lines, -5 lines 0 comments Download
M environs/sync/sync_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M environs/tools/build_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/tools/storage_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/tools/tools_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/tools/validation_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M instance/address_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M juju/apiconn_test.go View 13 chunks +16 lines, -15 lines 0 comments Download
M juju/conn_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M juju/osenv/package_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M juju/osenv/vars_linux_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M juju/osenv/vars_windows_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M juju/testing/conn.go View 2 chunks +3 lines, -2 lines 0 comments Download
M provider/azure/azure_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/azure/config_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/azure/customdata_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/ec2/config_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/ec2/image_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M provider/ec2/live_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M provider/ec2/local_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M provider/local/environprovider_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/local/local_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/local/prereqs_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/maas/config_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/maas/maas_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/openstack/config_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/openstack/live_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M provider/openstack/local_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M provider/state_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M rpc/jsoncodec/codec_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M rpc/rpc_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/apiserver/common/errors_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/conn_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/initialize_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/megawatcher_internal_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/multiwatcher/multiwatcher_internal_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M state/presence/presence_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/settings_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/watcher/watcher_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M store/store_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M testing/mgo_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M testing/testbase/cleanup.go View 1 chunk +1 line, -1 line 0 comments Download
M testing/testbase/cleanup_test.go View 1 chunk +6 lines, -3 lines 0 comments Download
M testing/testbase/imports.go View 1 chunk +1 line, -1 line 0 comments Download
M testing/testbase/log.go View 1 chunk +1 line, -1 line 0 comments Download
M testing/testbase/log_test.go View 1 chunk +6 lines, -3 lines 0 comments Download
A testing/testbase/package_test.go View 1 chunk +26 lines, -0 lines 1 comment Download
M testing/testbase/patch.go View 1 chunk +4 lines, -1 line 0 comments Download
M testing/testbase/patch_test.go View 8 chunks +11 lines, -8 lines 0 comments Download
M utils/fslock/fslock_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M worker/deployer/simple_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M worker/notifyworker_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/runner_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/stringsworker_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/charm/git_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M worker/uniter/debug/server_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/uniter/jujuc/server_test.go View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
thumper
Please take a look.
10 years, 7 months ago (2013-09-20 02:59:23 UTC) #1
axw1
10 years, 7 months ago (2013-09-20 03:08:24 UTC) #2
LGTM, just one question about dependencies.

https://codereview.appspot.com/13694046/diff/1/testing/testbase/package_test.go
File testing/testbase/package_test.go (right):

https://codereview.appspot.com/13694046/diff/1/testing/testbase/package_test....
testing/testbase/package_test.go:23: // This test is to ensure we don't bring in
any juju-core dependencies.
Glad to have this here. Is it okay for testbase to import testing/checkers?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b