Issue 136920043: Copy updated files from lib9/utf from upstream repository.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 136920043: Copy updated files from lib9/utf from upstream repository. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by roubert (google)

Modified:
9 years, 8 months ago

Reviewers:
Shaopeng

CC:
lararennie, pkasting, pliard1

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Copy updated files from lib9/utf from upstream repository. This also requires updating code that previously took a shortcut and depended on the Rune and char32 typedefs to be identical (which is no longer the case, as Rune is now unsigned). R=jia.shao.peng@gmail.com BUG= Committed: https://code.google.com/p/libphonenumber/source/detail?r=699

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -53 lines)			Patch
M	cpp/src/phonenumbers/utf/rune.c	View	16 chunks	+35 lines, -27 lines	0 comments	Download
M	cpp/src/phonenumbers/utf/unicodetext.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	cpp/src/phonenumbers/utf/unilib.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cpp/src/phonenumbers/utf/utf.h	View	7 chunks	+11 lines, -22 lines	0 comments	Download
M	cpp/src/phonenumbers/utf/utfdef.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Shaopeng

On 2014/08/28 13:26:25, roubert (google) wrote: LGTM. Since this is just syncing from upstream repository, ...

9 years, 8 months ago (2014-08-28 14:42:10 UTC) #2

roubert (google)

9 years, 8 months ago (2014-08-28 14:50:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 699 (presubmit successful).

Expand All Messages | Collapse All Messages