Issue 13683045: add some missing css pseudo-classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13683045: add some missing css pseudo-classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by felix8a

Modified:
12 years, 5 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

css added a lot of harmless pseudo-classes that we don't currently whitelist. This CL adds most of them.

Patch Set 1 #

Total comments: 2

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -7 lines)			Patch
	M	src/com/google/caja/plugin/CssRewriter.java	View		1 chunk	+55 lines, -4 lines	1 comment	Download
	M	src/com/google/caja/plugin/sanitizecss.js	View		1 chunk	+12 lines, -3 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kpreid2

LGTM https://codereview.appspot.com/13683045/diff/1/src/com/google/caja/plugin/CssRewriter.java File src/com/google/caja/plugin/CssRewriter.java (right): https://codereview.appspot.com/13683045/diff/1/src/com/google/caja/plugin/CssRewriter.java#newcode603 src/com/google/caja/plugin/CssRewriter.java:603: private static final TypesafeSet<Name> ALLOWED_PSEUDO_CLASSES = Suggest citing ...

12 years, 6 months ago (2013-09-18 00:08:47 UTC) #2

@r5598

Expand All Messages | Collapse All Messages