api/uniter: Rename charm Bundle to Archive

api/uniter: Rename charm Bundle to Archive

It was decided not to expose the term "bundle" through
the API, so that it's not confused with juju deployment
bundles. This renames two uniter API calls accordinly.

https://code.launchpad.net/~dimitern/juju-core/134-api-uniter-rename-bundle-to-archive/+merge/185283

Requires: https://code.launchpad.net/~dimitern/juju-core/133-apiserver-setagentalive-for-unit-agents/+merge/185280

(do not edit description out of merge proposal)

[dimitern, 2013-09-12 15:07:41]

Please take a look.

[mue, 2013-09-12 15:36:21]

LGTM

[natefinch, 2013-09-12 15:39:07]

I really don't like that we're calling the same thing by two different names in
different places.  Over here we're calling them archives, over there we're
calling them bundles. It should be one or the other everywhere, otherwise it's
confusing. If the only reason we don't want to change it everywhere is because
it'll be a lot of LOC.... that doesn't really seem like a good reason to make
our codebase more confusing.

[jameinel, 2013-09-12 16:21:41]

On 2013/09/12 15:39:07, nate.finch wrote:
> I really don't like that we're calling the same thing by two different names
in
> different places.  Over here we're calling them archives, over there we're
> calling them bundles. It should be one or the other everywhere, otherwise it's
> confusing. If the only reason we don't want to change it everywhere is because
> it'll be a lot of LOC.... that doesn't really seem like a good reason to make
> our codebase more confusing.

I think there are 2 bits to watch out for:

1) We should be migrating the internals over to Archive
2) It probably isn't worth changing the DB schema just for this, but it should
be on a TODO. Especially if we get to the point that most things are hidden
behind the API and we can clean up what is written to the DB.
3) Progress, not perfection. Bonus points for pushing more on (1), but it
doesn't have to finish today.

[jameinel, 2013-09-12 16:25:44]

If (1) won't happen soon, we should file a tech-debt bug and add comments to the
State.BundleURL functions.