Issue 13656044: cloudinit: set db directory to mode 0700

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13656044: cloudinit: set db directory to mode 0700

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by mue

Modified:
11 years, 6 months ago

Reviewers:
mp+185094, rog

Visibility:
Public.

Description

cloudinit: set db directory to mode 0700 Solving bug lp:1193443 changing the mode of the database directory to 0700 after creation. https://code.launchpad.net/~themue/juju-core/043-db-directory/+merge/185094 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	1 chunk	+1 line, -0 lines	2 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/13656044/diff/1/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/13656044/diff/1/environs/cloudinit/cloudinit.go#newcode303 environs/cloudinit/cloudinit.go:303: "chmod 0700 "+dbDir, alternatively pass "-m 700" to ...

11 years, 6 months ago (2013-09-11 16:19:10 UTC) #2

mue

11 years, 6 months ago (2013-09-11 16:30:17 UTC) #3

https://codereview.appspot.com/13656044/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/13656044/diff/1/environs/cloudinit/cloudinit.g...
environs/cloudinit/cloudinit.go:303: "chmod 0700 "+dbDir,
On 2013/09/11 16:19:10, rog wrote:
> alternatively pass "-m 700" to mkdir, though
> I don't know how universally accepted that flag is.

Staying with more conservative approach.

Expand All Messages | Collapse All Messages