Issue 13648048: lbox check always vets

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13648048: lbox check always vets

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mue, axw1, mp+185437

Visibility:
Public.

Description

lbox check always vets Since we're now using go1.1, we can always use go vet. Also fix a couple of errors that this caught. Also fix the dependencies.tsv file, which hadn't been updated for a recent gwacl change. https://code.launchpad.net/~rogpeppe/juju-core/392-go-vet-always/+merge/185437 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : lbox check always vets #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -20 lines)			Patch
M	.lbox.check	View	1	1 chunk	+6 lines, -11 lines	0 comments	Download
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/validateimagemetadata_test.go	View		1 chunk	+1 line, -1 line	1 comment	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dependencies.tsv	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/machiner/machiner.go	View		3 chunks	+5 lines, -6 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw1

On 2013/09/13 08:55:34, rog wrote: > Please take a look. LGTM

10 years, 7 months ago (2013-09-13 08:59:27 UTC) #2

mue

10 years, 7 months ago (2013-09-13 09:01:48 UTC) #3

Only minor comments, so LGTM.

https://codereview.appspot.com/13648048/diff/3001/cmd/plugins/juju-metadata/v...
File cmd/plugins/juju-metadata/validateimagemetadata_test.go (right):

https://codereview.appspot.com/13648048/diff/3001/cmd/plugins/juju-metadata/v...
cmd/plugins/juju-metadata/validateimagemetadata_test.go:103: c.Fatalf("unknown
ec2 region %q", region)
Ouch, yes, good catch.

https://codereview.appspot.com/13648048/diff/3001/worker/machiner/machiner.go
File worker/machiner/machiner.go (right):

https://codereview.appspot.com/13648048/diff/3001/worker/machiner/machiner.go...
worker/machiner/machiner.go:51: return nil, fmt.Errorf("%s failed to set status
started: %v", mr.tag, err)
Would have like to see this in an extra CL, but it's ok.

Expand All Messages | Collapse All Messages