Issue 13642045: Always show cmd errors/warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13642045: Always show cmd errors/warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by wallyworld

Modified:
10 years, 7 months ago

Reviewers:
mp+186738, gz

Visibility:
Public.

Description

Always show cmd errors/warnings Unless show-log was true, errors and warnings from running commands were not shown. This branch adds a log writer if show-log is false; the writer strips off time and date etc and just writes the core error and warning details to stderr. https://code.launchpad.net/~wallyworld/juju-core/default-logging/+merge/186738 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -12 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/main_test.go	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	cmd/juju/plugin_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/logging.go	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	cmd/logging_test.go	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	cmd/supercommand.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	cmd/supercommand_test.go	View	4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

10 years, 7 months ago (2013-09-20 10:10:20 UTC) #2

LGTM, well, this looks pretty much how you'd expect.

Was going to say add a colon to the stderr after level, but actually think I
prefer it without.

Expand All Messages | Collapse All Messages