|
various: gocheck, checkers, imports fixes
This fixes several things across the codebase:
* gocheck is imported as gc in every file
* testing/checkers is imported as jc in every file
* imports are properly grouped as standard, 3rd party and juju-core
https://code.launchpad.net/~dimitern/juju-core/137-fix-state-imports/+merge/185519
Requires: https://code.launchpad.net/~dimitern/juju-core/136-params-error-code-helpers/+merge/185461
(do not edit description out of merge proposal)
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+711 lines, -597 lines) |
Patch |
 |
A |
[revision details]
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cert/cert_test.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cmd/builddb/main.go
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
cmd/charmload/main.go
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/addmachine_test.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
cmd/juju/addrelation_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/addunit_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/cmd_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/constraints_test.go
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/deploy_test.go
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/destroymachine_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/destroyrelation_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/destroyservice_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/destroyunit_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/endpoint.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/expose_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/helptool_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/plugin_test.go
|
View
|
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/publish_test.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
cmd/juju/resolved_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/scp_test.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
cmd/juju/ssh_test.go
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/switch.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/switch_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/unexpose_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cmd/juju/upgradecharm_test.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cmd/jujud/main.go
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
cmd/jujud/main_test.go
|
View
|
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cmd/plugins/juju-metadata/metadataplugin_test.go
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
environs/cloudinit/suite_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
environs/config/home_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
environs/instances/image_test.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
environs/jujutest/jujutest_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
environs/jujutest/livetests.go
|
View
|
|
26 chunks |
+171 lines, -170 lines |
0 comments
|
Download
|
 |
M |
environs/jujutest/metadata_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
environs/jujutest/tests.go
|
View
|
|
6 chunks |
+65 lines, -65 lines |
0 comments
|
Download
|
 |
M |
environs/localstorage/backend_test.go
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
environs/simplestreams/datasource.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
environs/simplestreams/decode.go
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
environs/storage.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
environs/testing/tools.go
|
View
|
|
5 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
 |
M |
environs/tools/simplestreams.go
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
environs/tools/testing/testing.go
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
instance/instance_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
juju/conn_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
juju/testing/repo.go
|
View
|
|
3 chunks |
+30 lines, -28 lines |
0 comments
|
Download
|
 |
M |
log/syslog/config_test.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
names/environ.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
2 comments
|
Download
|
 |
M |
names/user.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
2 comments
|
Download
|
 |
M |
provider/azure/environprovider.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
provider/azure/storage.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
provider/ec2/config.go
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
provider/ec2/export_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
provider/ec2/instancetype.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
provider/ec2/suite_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
provider/openstack/config.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
provider/openstack/live_test.go
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
provider/provider_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
rpc/jsoncodec/codec.go
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
rpc/jsoncodec/codec_test.go
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
rpc/jsoncodec/conn.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
state/api/agent/state.go
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
state/api/apiclient.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
state/api/params/params.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/api/params/params_test.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
state/api/watcher/watcher.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
state/apiserver/admin.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
state/apiserver/apiserver.go
|
View
|
|
1 chunk |
+8 lines, -6 lines |
0 comments
|
Download
|
 |
M |
state/apiserver/client/api_test.go
|
View
|
|
3 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
state/apiserver/client/client_test.go
|
View
|
|
4 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
state/apiserver/common/resource.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
state/apiserver/login_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/apiserver/utils.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/charm_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
state/initialize_test.go
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
state/machine_test.go
|
View
|
|
5 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
state/multiwatcher/multiwatcher.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
state/multiwatcher/multiwatcher_internal_test.go
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
state/presence/presence.go
|
View
|
|
1 chunk |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
state/presence/presence_test.go
|
View
|
|
1 chunk |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
state/relation.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
state/relation_test.go
|
View
|
|
6 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
state/relationunit.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
state/service_test.go
|
View
|
|
12 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
 |
M |
state/settings_test.go
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
state/statecmd/addrelation_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/statecmd/destroyrelation_test.go
|
View
|
|
4 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
state/statecmd/destroyservice_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/statecmd/expose_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/statecmd/unexpose_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
state/unit.go
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
state/unit_test.go
|
View
|
|
7 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
state/watcher/helpers_test.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
state/watcher/watcher.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
state/watcher/watcher_test.go
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
store/mgo_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/bool.go
|
View
|
|
2 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/bool_test.go
|
View
|
|
3 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/checker.go
|
View
|
|
7 chunks |
+19 lines, -19 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/file.go
|
View
|
|
3 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/file_test.go
|
View
|
|
4 chunks |
+21 lines, -20 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/relop.go
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/relop_test.go
|
View
|
|
2 chunks |
+14 lines, -13 lines |
0 comments
|
Download
|
 |
M |
testing/checkers/set_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
testing/cmd.go
|
View
|
|
6 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
testing/environ.go
|
View
|
|
7 chunks |
+20 lines, -20 lines |
0 comments
|
Download
|
 |
M |
testing/git.go
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
testing/http.go
|
View
|
|
1 chunk |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
testing/instance.go
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
testing/log_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
testing/mgo.go
|
View
|
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
tools/list.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
utils/attempt_test.go
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
utils/fslock/fslock_test.go
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
utils/set/strings_test.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
utils/uuid_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
worker/deployer/simple_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
worker/firewaller/firewaller.go
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
worker/provisioner/provisioner_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
worker/resumer/resumer.go
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
worker/resumer/resumer_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
worker/uniter/charm/charm_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
worker/uniter/jujuc/ports_test.go
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
worker/uniter/jujuc/server_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
worker/uniter/relation/relation_test.go
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
worker/uniter/relationer_test.go
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
Total messages: 2
|