code review 136000043: syscall: use go generate to build zsyscall_windows.go

syscall: use go generate to build zsyscall_windows.go

[brainman, 2014-08-29 06:54:35]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2014-09-02 18:14:55]

NOT LGTM

Let's leave syscall alone for now.

[brainman, 2014-09-03 05:06:56]

On 2014/09/02 18:14:55, r wrote:
> NOT LGTM
> 
> Let's leave syscall alone for now.

Sure. But we will need mksyscall_windows.go program (with all changes made in
this CL) to generate zsyscall_windows.go file in both
$GOROOT/pkg/internal/syscall and go.sys/windows. Where should this
mksyscall_windows.go live? I was hoping we will maintain a single copy in
$GOROOT/pkg/syscall/mksyscall_windows.go, and use "go generate ..." everywhere.

Alex

[r, 2014-09-09 18:47:15]

OK, things are settled again now.

I would like to get go.sys and syscall in sync and good for Windows. Can we
leave go generate out of the loop for the moment? The other OSes don't go there
yet.

[brainman, 2014-09-09 23:59:27]

On 2014/09/09 18:47:15, r wrote:
> 
> I would like to get go.sys and syscall in sync and good for Windows. Can we
> leave go generate out of the loop for the moment? The other OSes don't go
there
> yet.

Sure. Lets forget about "go generate" for windows syscall for now.

Alex

[gobot, 2014-12-19 05:12:42]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/136000043 is best) in the description in your
new CL.

Thanks very much.