Issue 13594044: provider/dummy: actually destroy environ

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13594044: provider/dummy: actually destroy environ

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mp+187078, natefinch, jameinel

Visibility:
Public.

Description

provider/dummy: actually destroy environ Dummy comes one step closer to other providers. This also meant that some of the jujutest tests needed changing, with consequent changes in other providers. In particular, the Env field in the local tests is dropped as being unnecessary, and the live tests require each test to state what they want the Environ to be (prepared or bootstrapped). https://code.launchpad.net/~rogpeppe/juju-core/416-dummy-prepared-flag/+merge/187078 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -124 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2	11 chunks	+34 lines, -17 lines	0 comments	Download
M	environs/jujutest/tests.go	View		5 chunks	+14 lines, -16 lines	0 comments	Download
M	provider/dummy/environs.go	View		2 chunks	+22 lines, -6 lines	0 comments	Download
M	provider/dummy/environs_test.go	View		1 chunk	+15 lines, -4 lines	0 comments	Download
M	provider/ec2/local_test.go	View		11 chunks	+40 lines, -28 lines	0 comments	Download
M	provider/local/environ_test.go	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	provider/openstack/live_test.go	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	provider/openstack/local_test.go	View		21 chunks	+64 lines, -52 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jameinel

LGTM though I don't think we need to check the boolean 2 times. https://codereview.appspot.com/13594044/diff/3001/environs/jujutest/livetests.go File ...

10 years, 7 months ago (2013-09-24 07:06:47 UTC) #3

rog

10 years, 7 months ago (2013-09-24 07:16:01 UTC) #4

Please take a look.

https://codereview.appspot.com/13594044/diff/3001/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/13594044/diff/3001/environs/jujutest/livetests...
environs/jujutest/livetests.go:121: t.PrepareOnce(c)
On 2013/09/24 07:06:48, jameinel wrote:
> Given you have the "if t.prepared" in PrepareOnce, I think it makes sense to
> just call it. We already just call BootstrapOnce everywhere so we don't have
to
> think about that flag.

Good point. Done.

Expand All Messages | Collapse All Messages