Issue 13587046: environs: remove instances arg to Destroy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13587046: environs: remove instances arg to Destroy

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mue, mp+187177

Visibility:
Public.

Description

environs: remove instances arg to Destroy In all practical cases, this would not make a difference and there weren't even any tests using the functionality. Since it's always possible to get the same effect by calling StopInstances before calling Destroy, the argument is redundant and is therefore removed. https://code.launchpad.net/~rogpeppe/juju-core/417-simplify-environ-destroy/+merge/187177 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: remove instances arg to Destroy #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -93 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/destroyenvironment.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/interface.go	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/jujutest/tests.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/azure/environ.go	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	provider/azure/environ_test.go	View	6 chunks	+5 lines, -15 lines	0 comments	Download
M	provider/dummy/environs.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/ec2/ec2.go	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	provider/ec2/local_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/local/environ.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/maas/environ.go	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	provider/maas/environ_test.go	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	provider/openstack/local_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	provider/openstack/provider.go	View	1 chunk	+1 line, -13 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mue

10 years, 7 months ago (2013-09-24 09:54:47 UTC) #2

LGTM, nice cleanup. (And there's still so much code duplication in the
providers.)

Expand All Messages | Collapse All Messages