code review 135820043: unicode: use go generate instead of make to create tables.go

src/pkg/unicode/letter.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // Package unicode provides data and functions to test some properties of
 // Unicode code points.
 package unicode
 
 // Tables are regenerated each time we update the Unicode version.
-//go:generate go build maketables.go
-//go:generate ./maketables --tables=all -output tables.go

[mpvl, 2014/08/26 19:13:16]

Any reason not to make it `go run maketables.go --tables=all -output tables.go`?

This way it won't leave a binary lingering.

+//go:generate go run maketables.go -tables=all -output tables.go
 
 const (
         MaxRune         = '\U0010FFFF' // Maximum valid Unicode code point.
         ReplacementChar = '\uFFFD'     // Represents invalid code points.
         MaxASCII        = '\u007F'     // maximum ASCII value.
         MaxLatin1       = '\u00FF'     // maximum Latin-1 value.
 )
 
 // RangeTable defines a set of Unicode code points by listing the ranges of
 // code points within the set. The ranges are listed in two slices
@@ skipping 327 matching lines @@
         }
 
         // No folding specified.  This is a one- or two-element
         // equivalence class containing rune and ToLower(rune)
         // and ToUpper(rune) if they are different from rune.
         if l := ToLower(r); l != r {
                 return l
         }
         return ToUpper(r)
 }