Issue 13568048: Fix compiler test initialization issues.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13568048: Fix compiler test initialization issues. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Zhenyao Mo

Modified:
10 years, 7 months ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com, kbr1, Shannon Woods

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Fix compiler test initialization issues. We should call ShInitialize() / ShFinalize() once per process, so moving them out of individual test's Setup() / Shutdown() to the test main(). BUG= R=alokp@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=16a3eb3

Patch Set 1 : #

Patch Set 2 : update version #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
M	src/common/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/build_tests.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler_tests/ExpressionLimit_test.cpp	View		1 chunk	+0 lines, -8 lines	0 comments	Download
A	tests/compiler_tests/compiler_test_main.cpp	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Zhenyao Mo

Alok, please review (you can click on the file name to see the diff file. ...

10 years, 7 months ago (2013-09-24 00:13:52 UTC) #1

Zhenyao Mo

10 years, 7 months ago (2013-09-25 23:32:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16a3eb3 (presubmit successful).

Expand All Messages | Collapse All Messages