Add benchmark option to run on workers

Add benchmark option to run on workers

R=tyoshino@chromium.org

Committed: https://code.google.com/p/pywebsocket/source/detail?r=842

[tyoshino (chromium.org), 2014-09-10 04:28:26]

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:68: else {
put else on the same line as the closing brace for if.

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:81: else {
ditto

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:94: else {
ditto

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:107: else {
ditto

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.js
File src/example/benchmark.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.js#newc...
src/example/benchmark.js:97: config.addToLog('Expected ' + size + 'B but
received ' + bytesReceived + 'B');
79 col

https://codereview.appspot.com/135620043/diff/1/src/example/util.js
File src/example/util.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/util.js#newcode176
src/example/util.js:176: console.log(newObj);
forgot to remove these two lines? or wanna keep for debugging?

https://codereview.appspot.com/135620043/diff/1/src/example/util_main.js
File src/example/util_main.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/util_main.js#newc...
src/example/util_main.js:50: function onMessage (message) {
no space between a function name and an open parenthesis

https://codereview.appspot.com/135620043/diff/1/src/example/util_worker.js
File src/example/util_worker.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/util_worker.js#ne...
src/example/util_worker.js:9: function workerAddToLog (text) {
no space between a function name and an open parenthesis

https://codereview.appspot.com/135620043/diff/1/src/example/util_worker.js#ne...
src/example/util_worker.js:13: function workerAddToSummary (text) {
ditto

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.html
File src/example/xhr_benchmark.html (right):

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:65: config.responseType =
getStringFromRadioBox('responsetyperadio');
Ah. This variable should be renamed to something else as it's currently used not
only for responseType but to determine the type of data to pass to send() method
in sendBenchmarkStep().

Could you please do it either in this CL or in a separate CL?

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:84: else {
on the same line as the closing brace for if

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:97: else {
ditto

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:110: else {
ditto

[hiroshige, 2014-09-10 05:54:18]

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html
File src/example/benchmark.html (right):

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:68: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> put else on the same line as the closing brace for if.

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:81: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> ditto

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:94: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> ditto

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#ne...
src/example/benchmark.html:107: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> ditto

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.js
File src/example/benchmark.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.js#newc...
src/example/benchmark.js:97: config.addToLog('Expected ' + size + 'B but
received ' + bytesReceived + 'B');
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> 79 col

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/util.js
File src/example/util.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/util.js#newcode176
src/example/util.js:176: console.log(newObj);
Done. Removed.

https://codereview.appspot.com/135620043/diff/1/src/example/util_main.js
File src/example/util_main.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/util_main.js#newc...
src/example/util_main.js:50: function onMessage (message) {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> no space between a function name and an open parenthesis

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/util_worker.js
File src/example/util_worker.js (right):

https://codereview.appspot.com/135620043/diff/1/src/example/util_worker.js#ne...
src/example/util_worker.js:9: function workerAddToLog (text) {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> no space between a function name and an open parenthesis

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/util_worker.js#ne...
src/example/util_worker.js:13: function workerAddToSummary (text) {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> ditto

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.html
File src/example/xhr_benchmark.html (right):

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:65: config.responseType =
getStringFromRadioBox('responsetyperadio');
OK, I'll do this in a separate CL.
Rename responseType to dataType or something?
Do you have any suggestion for the name?

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:84: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> on the same line as the closing brace for if

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:97: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> ditto

Done.

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:110: else {
On 2014/09/10 04:28:26, tyoshino (Chromium) wrote:
> ditto

Done.

[tyoshino (chromium.org), 2014-09-10 05:59:14]

lgtm

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.html
File src/example/xhr_benchmark.html (right):

https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.htm...
src/example/xhr_benchmark.html:65: config.responseType =
getStringFromRadioBox('responsetyperadio');
On 2014/09/10 05:54:18, hiroshige wrote:
> OK, I'll do this in a separate CL.
> Rename responseType to dataType or something?
> Do you have any suggestion for the name?

dataType sounds ok.

[hiroshige, 2014-09-10 06:57:14]

Committed patchset #3 (id:60001) manually as r842 (presubmit successful).