Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 135620043: Add benchmark option to run on workers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by hiroshige
Modified:
11 years, 7 months ago
CC:
pywebsocket-reviews_googlegroups.com
Base URL:
http://pywebsocket.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add benchmark option to run on workers R=tyoshino@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=842

Patch Set 1 #

Total comments: 27

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -648 lines) Patch
M src/example/benchmark.html View 1 4 chunks +44 lines, -268 lines 0 comments Download
A src/example/benchmark.js View 1 1 chunk +287 lines, -0 lines 0 comments Download
M src/example/util.js View 1 8 chunks +20 lines, -40 lines 0 comments Download
A src/example/util_main.js View 1 1 chunk +55 lines, -0 lines 0 comments Download
A src/example/util_worker.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/example/xhr_benchmark.html View 1 4 chunks +47 lines, -340 lines 0 comments Download
A src/example/xhr_benchmark.js View 1 chunk +357 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hiroshige
11 years, 7 months ago (2014-09-09 09:48:55 UTC) #1
tyoshino (chromium.org)
https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html File src/example/benchmark.html (right): https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#newcode68 src/example/benchmark.html:68: else { put else on the same line as ...
11 years, 7 months ago (2014-09-10 04:28:26 UTC) #2
hiroshige
https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html File src/example/benchmark.html (right): https://codereview.appspot.com/135620043/diff/1/src/example/benchmark.html#newcode68 src/example/benchmark.html:68: else { On 2014/09/10 04:28:26, tyoshino (Chromium) wrote: > ...
11 years, 7 months ago (2014-09-10 05:54:18 UTC) #3
tyoshino (chromium.org)
lgtm https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.html File src/example/xhr_benchmark.html (right): https://codereview.appspot.com/135620043/diff/1/src/example/xhr_benchmark.html#newcode65 src/example/xhr_benchmark.html:65: config.responseType = getStringFromRadioBox('responsetyperadio'); On 2014/09/10 05:54:18, hiroshige wrote: ...
11 years, 7 months ago (2014-09-10 05:59:14 UTC) #4
hiroshige
11 years, 7 months ago (2014-09-10 06:57:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as r842 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b