Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2535)

Issue 13561043: api/uniter: Split uniter API client tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dimitern
Modified:
10 years, 8 months ago
Reviewers:
mue, gz, mp+184110
Visibility:
Public.

Description

api/uniter: Split uniter API client tests Since the client-side uniter API tests start to grow a lot, this splits them in separate files, while taking some steps to reduce duplication and reuse common code. https://code.launchpad.net/~dimitern/juju-core/121-api-uniter-split-tests/+merge/184110 Requires: https://code.launchpad.net/~dimitern/juju-core/120-api-relationunitswatcher-client/+merge/184044 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -434 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A state/api/uniter/relationunit_test.go View 1 chunk +78 lines, -0 lines 0 comments Download
A state/api/uniter/unit_test.go View 1 chunk +389 lines, -0 lines 0 comments Download
M state/api/uniter/uniter_test.go View 4 chunks +15 lines, -434 lines 0 comments Download

Messages

Total messages: 3
dimitern
Please take a look.
10 years, 8 months ago (2013-09-05 14:01:55 UTC) #1
gz
LGTM.
10 years, 8 months ago (2013-09-05 14:16:43 UTC) #2
mue
10 years, 8 months ago (2013-09-05 14:21:13 UTC) #3
Nice, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b