Issue 13552046: worker: Use WatchForEnvironConfigChanges()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13552046: worker: Use WatchForEnvironConfigChanges() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dimitern

Modified:
11 years, 6 months ago

Reviewers:
mue, mp+186306, rog

Visibility:
Public.

Description

worker: Use WatchForEnvironConfigChanges() This is a prerequisite step to implementing the rest of the provisioner API. It changes the two workers that use an EnvironConfigWatcher (currently only the provisioner and firewaller) to use a NotifyWatcher, returned by WatchForEnvironChanges(), and getting the actual environment configuration when a change is detected. As a drive-by fix, a weird test helper in the provisioner tests was fixed to invalidate an environment configuration in a more obvious way. https://code.launchpad.net/~dimitern/juju-core/140-provisioner-watchforenvironconfigchanges/+merge/186306 Requires: https://code.launchpad.net/~dimitern/juju-core/139-apiserver-provisioner/+merge/186019 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -30 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/environ.go	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	worker/firewaller/firewaller.go	View	4 chunks	+9 lines, -5 lines	0 comments	Download
M	worker/provisioner/provisioner.go	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	6 chunks	+12 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

On 2013/09/18 12:44:38, mue wrote:
> LGTM

LGTM too

Expand All Messages | Collapse All Messages