Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(393)

Issue 13544043: Add JS globals to guest-created iframes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by kpreid_google
Modified:
12 years, 6 months ago
Reviewers:
felix8a, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

For guests with DOM access, the copyToImports is done in a function passed to Domado rather than separately in the frame group. This refactoring allows virtual documents for iframes to also obtain their imports. Note that host-provided extra imports will _not_ be added to iframes; There is no especially strong reason for this behavior, but it was simpler and fits with (in browsers in general) iframes being a way to create a "fresh" environment with no application-specific global state. @r5593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M src/com/google/caja/plugin/domado.js View 3 chunks +7 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/es53-frame-group.js View 1 chunk +5 lines, -4 lines 0 comments Download
M src/com/google/caja/plugin/ses-frame-group.js View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/test-domado-iframe-guest.html View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kpreid_google
12 years, 6 months ago (2013-09-04 22:17:09 UTC) #1
kpreid_google
ping
12 years, 6 months ago (2013-09-09 17:56:06 UTC) #2
felix8a
lgtm > Note that host-provided extra imports will _not_ be added to iframes; > there ...
12 years, 6 months ago (2013-09-09 18:05:42 UTC) #3
kpreid_google
12 years, 6 months ago (2013-09-09 18:46:43 UTC) #4
On 2013/09/09 18:05:42, felix8a wrote:
> > Note that host-provided extra imports will _not_ be added to iframes;
> > there is no strong reason for this, however.
> 
> maybe add a note somewhere about that?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b