Issue 13535045: environs/configstorage: new package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13535045: environs/configstorage: new package

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
axw1, mp+185538

Visibility:
Public.

Description

environs/configstorage: new package We introduce the environs.ConfigStorage interface and one implementation, reading and writing from a directory. https://code.launchpad.net/~rogpeppe/juju-core/395-environ-info-storage-implementation/+merge/185538 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/configstorage: new package #

Patch Set 3 : environs/configstorage: new package #

Patch Set 4 : environs/configstorage: new package #

Patch Set 5 : environs/configstorage: new package #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -1 line)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A	environs/configstore/disk.go	View	1 2 3	1 chunk	+66 lines, -0 lines	0 comments	Download
A	environs/configstore/disk_test.go	View	1 2 3	1 chunk	+74 lines, -0 lines	0 comments	Download
A	environs/configstore/package_test.go	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	environs/info.go	View	1 2 3	1 chunk	+41 lines, -0 lines	0 comments	Download
M	environs/sshstorage/storage.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw1

10 years, 7 months ago (2013-09-16 14:32:13 UTC) #3

On 2013/09/16 13:50:00, rog wrote:
> Please take a look.

The code itself LGTM, though I must admit I don't understand all of the
requirements.

Expand All Messages | Collapse All Messages