Issue 13527046: optimize unbind

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13527046: optimize unbind (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rafaelw

Modified:
11 years, 7 months ago

Reviewers:
arv

Base URL:
https://github.com/Polymer/NodeBind.git@master

Visibility:
Public.

More Reviews

Description

optimize unbind R=arv BUG= Committed: https://github.com/Polymer/NodeBind/commit/8e33d67

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/NodeBind.js	View		1 chunk	+5 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r8e33d67 (presubmit successful).

11 years, 7 months ago (2013-09-05 21:41:06 UTC) #1

arv

https://codereview.appspot.com/13527046/diff/1/src/NodeBind.js File src/NodeBind.js (right): https://codereview.appspot.com/13527046/diff/1/src/NodeBind.js#newcode57 src/NodeBind.js:57: var binding = this.bindings[name]; var binding = this.bindings[name]; if ...

11 years, 7 months ago (2013-09-05 22:52:53 UTC) #2

rafaelw

11 years, 7 months ago (2013-09-05 23:01:38 UTC) #3

Message was sent while issue was closed.

https://github.com/Polymer/NodeBind/commit/9e22af59a90a8df3a3ae95a6f576be5958...

https://codereview.appspot.com/13527046/diff/1/src/NodeBind.js
File src/NodeBind.js (right):

https://codereview.appspot.com/13527046/diff/1/src/NodeBind.js#newcode57
src/NodeBind.js:57: var binding = this.bindings[name];
On 2013/09/05 22:52:53, arv wrote:
> var binding = this.bindings[name];
> if (!binding)
>   return;

Done.

Expand All Messages | Collapse All Messages