UI for toggling history between names and itemid.

UI for toggling history between names and itemid.

[Thomas.J.Waldmann, 2013-09-05 08:42:23]

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/apps/frontend/view...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/apps/frontend/view...
MoinMoin/apps/frontend/views.py:933: terms.append(Term(term, value))
terms.extend(Term(term, value) for term, value in fqname.query.iteritems())

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/apps/frontend/view...
MoinMoin/apps/frontend/views.py:943: result = dict((k, v) for k, v in
rev.meta.iteritems() if k != CONTENT)
is that the same as:

entry = dict(rev.meta)
del entry[CONTENT]

?

I was using entry rather than result, because it gets more clear that this is
one entry in a list of potentially many.

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
File MoinMoin/templates/history.html (right):

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
MoinMoin/templates/history.html:4: {% set title = _("History of '%(fqname)s'",
fqname=fqname|shorten_fqname) %}
that looks a bit strange if it just says the itemid there. think of rather
non-technical users.

i don't have an idea right now how to make it better, though.

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
MoinMoin/templates/history.html:25: <th>{{ _("Itemid") }}</th>
if that is a new string, I would prefer "Item ID"

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
MoinMoin/templates/history.html:44: <td class="moin-wordbreak"><a href="{{
url_for_item(doc.itemid, field='itemid', namespace=fqname.namespace,
endpoint='frontend.history') }}">{{ doc.itemid|shorten_id }}</a></td>
format this in a similar style as the else block

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
MoinMoin/templates/history.html:71: {% if user.may.destroy(fqname) -%}
btw, did you already fix the may.xxx() code to accept fqnames?

[ashu1461, 2013-09-05 10:01:35]

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
File MoinMoin/templates/history.html (right):

https://codereview.appspot.com/13527045/diff/3001/MoinMoin/templates/history....
MoinMoin/templates/history.html:71: {% if user.may.destroy(fqname) -%}
On 2013/09/05 08:42:23, Thomas.J.Waldmann wrote:
> btw, did you already fix the may.xxx() code to accept fqnames?
Yes, I have fixed the protecting.py file already.

[ashu1461, 2013-09-05 10:06:10]

https://codereview.appspot.com/13527045/diff/19001/MoinMoin/apps/frontend/vie...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/13527045/diff/19001/MoinMoin/apps/frontend/vie...
MoinMoin/apps/frontend/views.py:890: 
Please ignore these changes, they are due to the merge.

[Thomas.J.Waldmann, 2013-09-05 18:55:18]

https://codereview.appspot.com/13527045/diff/19001/MoinMoin/apps/frontend/vie...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/13527045/diff/19001/MoinMoin/apps/frontend/vie...
MoinMoin/apps/frontend/views.py:1020: query = And([query, DateRange(MTIME,
start=datetime.utcfromtimestamp(bookmark_time), end=None)])
not your fault, but this meanwhile looks like it should be a list of queries and
the And() been done at the very end.

if you like to fix, separate cs.

https://codereview.appspot.com/13527045/diff/19001/MoinMoin/templates/history...
File MoinMoin/templates/history.html (right):

https://codereview.appspot.com/13527045/diff/19001/MoinMoin/templates/history...
MoinMoin/templates/history.html:44: <td class="moin-wordbreak"><a href="{{
url_for_item(doc.itemid, field='itemid', namespace=fqname.namespace,
endpoint='frontend.history') }}">{{ doc.itemid|shorten_id }}</a></td>
it still is all in one line. that is what I meant.