Issue 13525043: 1.17: Clirr fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13525043: 1.17: Clirr fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by peleyal

Modified:
12 years, 3 months ago

Reviewers:
yanivi

CC:
ngmiceli

Base URL:
https://code.google.com/p/google-api-java-client/

Visibility:
Public.

More Reviews

Patch Set 2 : yanivi comments #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	clirr-ignored-differences.xml	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

yanivi

LGTM (assuming the minor issues are fixed) https://codereview.appspot.com/13525043/diff/1/clirr-ignored-differences.xml File clirr-ignored-differences.xml (right): https://codereview.appspot.com/13525043/diff/1/clirr-ignored-differences.xml#newcode34 clirr-ignored-differences.xml:34: <!-- 7006 ...

12 years, 3 months ago (2013-09-04 13:37:06 UTC) #2

peleyal

12 years, 3 months ago (2013-09-04 16:07:44 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/13525043/diff/1/clirr-ignored-differences.xml
File clirr-ignored-differences.xml (right):

https://codereview.appspot.com/13525043/diff/1/clirr-ignored-differences.xml#...
clirr-ignored-differences.xml:34: <!-- 7006 Method Return Type changed -->
On 2013/09/04 13:37:06, yanivi wrote:
> please sort by difference type number

Done.

https://codereview.appspot.com/13525043/diff/1/clirr-ignored-differences.xml#...
clirr-ignored-differences.xml:41: <!-- 7005 (Method Argument Type changed):
className, method, to (to is a full new signature) -->
On 2013/09/04 13:37:06, yanivi wrote:
> please indent 

Done.

https://codereview.appspot.com/13525043/diff/1/clirr-ignored-differences.xml#...
clirr-ignored-differences.xml:42: <!-- Notice: Clirr shows ArrayList cast bug
On 2013/09/04 13:37:06, yanivi wrote:
> I prefer to show this;
> 
> [ERROR] com.google.api.client.googleapis.auth.oauth2.GoogleIdToken$Payload:
> Parameter 1 of 'public
> com.google.api.client.googleapis.auth.oauth2.GoogleIdToken$Payload
> setEmailVerified(boolean)' has changed its type to java.lang.Boolean
> 
> to make it easier to us to identify that this error should be ignored when
> running mvn -q clirr:check

Done.

Expand All Messages | Collapse All Messages