Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7556)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 13512049: worker/apiuniter: Clone uniter, fix imports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dimitern
Modified:
10 years, 7 months ago
Reviewers:
mp+184763, rog
Visibility:
Public.

Description

worker/apiuniter: Clone uniter, fix imports This clones the worker/uniter package as worker/apiuniter and fixes all imports order and separation. No other changes to code. It's a first step to the uniter state to API migration. We need this so when the follow-up comes with the API changes, the diff will be easier to follow. https://code.launchpad.net/~dimitern/juju-core/129-apiuniter/+merge/184763 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11402 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/charm.go View 1 chunk +100 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/charm_test.go View 1 chunk +137 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/deployer.go View 1 chunk +210 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/deployer_test.go View 1 chunk +224 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/export_test.go View 1 chunk +14 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/git.go View 1 chunk +224 lines, -0 lines 0 comments Download
A worker/apiuniter/charm/git_test.go View 1 chunk +241 lines, -0 lines 0 comments Download
A worker/apiuniter/context.go View 1 chunk +366 lines, -0 lines 0 comments Download
A worker/apiuniter/context_test.go View 1 chunk +652 lines, -0 lines 0 comments Download
A worker/apiuniter/debug/client.go View 1 chunk +120 lines, -0 lines 0 comments Download
A worker/apiuniter/debug/client_test.go View 1 chunk +47 lines, -0 lines 0 comments Download
A worker/apiuniter/debug/common.go View 1 chunk +35 lines, -0 lines 0 comments Download
A worker/apiuniter/debug/common_test.go View 1 chunk +30 lines, -0 lines 0 comments Download
A worker/apiuniter/debug/server.go View 1 chunk +116 lines, -0 lines 0 comments Download
A worker/apiuniter/debug/server_test.go View 1 chunk +204 lines, -0 lines 0 comments Download
A worker/apiuniter/filter.go View 1 chunk +515 lines, -0 lines 0 comments Download
A worker/apiuniter/filter_test.go View 1 chunk +443 lines, -0 lines 0 comments Download
A worker/apiuniter/hook/hook.go View 1 chunk +43 lines, -0 lines 0 comments Download
A worker/apiuniter/hook/hook_test.go View 1 chunk +61 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/config-get.go View 1 chunk +77 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/config-get_test.go View 1 chunk +178 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/context.go View 1 chunk +133 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/juju-log.go View 1 chunk +69 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/juju-log_test.go View 1 chunk +99 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/ports.go View 1 chunk +104 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/ports_test.go View 1 chunk +111 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-get.go View 1 chunk +101 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-get_test.go View 1 chunk +264 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-ids.go View 1 chunk +68 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-ids_test.go View 1 chunk +157 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-list.go View 1 chunk +60 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-list_test.go View 1 chunk +173 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-set.go View 1 chunk +72 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/relation-set_test.go View 1 chunk +225 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/server.go View 1 chunk +183 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/server_test.go View 1 chunk +219 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/unit-get.go View 1 chunk +61 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/unit-get_test.go View 1 chunk +92 lines, -0 lines 0 comments Download
A worker/apiuniter/jujuc/util_test.go View 1 chunk +197 lines, -0 lines 0 comments Download
A worker/apiuniter/modes.go View 1 chunk +424 lines, -0 lines 0 comments Download
A worker/apiuniter/relation/hookqueue.go View 1 chunk +390 lines, -0 lines 0 comments Download
A worker/apiuniter/relation/hookqueue_test.go View 1 chunk +298 lines, -0 lines 0 comments Download
A worker/apiuniter/relation/relation.go View 1 chunk +232 lines, -0 lines 0 comments Download
A worker/apiuniter/relation/relation_test.go View 1 chunk +351 lines, -0 lines 0 comments Download
A worker/apiuniter/relationer.go View 1 chunk +149 lines, -0 lines 0 comments Download
A worker/apiuniter/relationer_test.go View 1 chunk +426 lines, -0 lines 0 comments Download
A worker/apiuniter/state.go View 1 chunk +150 lines, -0 lines 0 comments Download
A worker/apiuniter/state_test.go View 1 chunk +170 lines, -0 lines 0 comments Download
A worker/apiuniter/tools.go View 1 chunk +31 lines, -0 lines 0 comments Download
A worker/apiuniter/tools_test.go View 1 chunk +69 lines, -0 lines 0 comments Download
A worker/apiuniter/uniter.go View 1 chunk +535 lines, -0 lines 0 comments Download
A worker/apiuniter/uniter_test.go View 1 chunk +1750 lines, -0 lines 0 comments Download

Messages

Total messages: 2
dimitern
Please take a look.
10 years, 7 months ago (2013-09-10 12:25:41 UTC) #1
rog
10 years, 7 months ago (2013-09-10 12:27:55 UTC) #2 
On 2013/09/10 12:25:41, dimitern wrote:
> Please take a look.

LGTM assuming no changes other than import path rewrites.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b