Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(374)

Issue 135053: Some extensions to Expression (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by MikeSamuel
Modified:
16 years, 7 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added code to conservatively figure out what a typeof <the expression> would yield, and conservative folding. These help with static analysis and code optimization. And added a static utility method Operation.is(ParseTreeNode, Operator) to replace a frequently appearing but hard to read idiom. Submitted @3825

Patch Set 1 #

Patch Set 2 : Some extensions to Expression #

Total comments: 4

Patch Set 3 : Some extensions to Expression #

Patch Set 4 : Some extensions to Expression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -25 lines) Patch
M src/com/google/caja/parser/js/AbstractExpression.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ArrayConstructor.java View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/com/google/caja/parser/js/BooleanLiteral.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/com/google/caja/parser/js/CajoledModuleExpression.java View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/com/google/caja/parser/js/Declaration.java View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/js/Expression.java View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/FunctionConstructor.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/NoChildren.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/NullLiteral.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/NumberLiteral.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ObjectConstructor.java View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/com/google/caja/parser/js/Operation.java View 1 2 3 5 chunks +243 lines, -6 lines 0 comments Download
M src/com/google/caja/parser/js/Parser.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/com/google/caja/parser/js/QuotedExpression.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/RealLiteral.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/parser/js/Reference.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/RegexpLiteral.java View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/StringLiteral.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/AlphaRenaming.java View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M tests/com/google/caja/parser/js/ExpressionTest.java View 1 2 3 2 chunks +107 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/templates/JsConcatenatorTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
MikeSamuel
16 years, 7 months ago (2009-10-19 22:29:51 UTC) #1
metaweta
LGTM modulo the one extra test http://codereview.appspot.com/135053/diff/1002/46 File tests/com/google/caja/parser/js/ExpressionTest.java (right): http://codereview.appspot.com/135053/diff/1002/46#newcode143 Line 143: } Test ...
16 years, 7 months ago (2009-10-22 01:26:58 UTC) #2
MikeSamuel
http://codereview.appspot.com/135053/diff/1002/46 File tests/com/google/caja/parser/js/ExpressionTest.java (right): http://codereview.appspot.com/135053/diff/1002/46#newcode143 Line 143: } On 2009/10/22 01:26:58, metaweta wrote: > Test ...
16 years, 7 months ago (2009-10-22 01:42:03 UTC) #3
metaweta
16 years, 7 months ago (2009-10-22 05:27:11 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b