Some cleanup

Made ordering of script loading in domita_test consistent with that in
domita-minified.js, and made sure domita-minified includes the html
sanitizer, which is now required by the html-emitter because of
document.write support.

Fixed minor problem with SafeIdentifierMaker -- the name "eval" has
special significance, so make sure it doesn't output it.  This is
unlikely to have happened in practice, since the code is unused, and
would only surface if run over a file with more than 5 * pow(26, 3)
identifiers.

Added a consistency check to FunctionDeclaration.

Cleaned up uses of feature detection in bridal.js.

Added an iterators utility class to make it easy to implement
SafeIdentifierMaker as a filter operation over a stream of candidate
names.


Submitted @3807

[metaweta, 2009-10-19 23:07:22]

LGTM

I like the SafeIdentifierMaker test.

[DavidSarah, 2009-10-20 01:40:36]

http://codereview.appspot.com/135052/diff/1/7
File src/com/google/caja/util/SafeIdentifierMaker.java (right):

http://codereview.appspot.com/135052/diff/1/7#newcode74
Line 74: // thrown.
Also, "eval" and "arguments" (see http://bugs.ecmascript.org/ticket/467 ) are
not allowed as identifiers in ES5 strict mode.

[DavidSarah, 2009-10-20 01:42:49]

http://codereview.appspot.com/135052/diff/1/7
File src/com/google/caja/util/SafeIdentifierMaker.java (right):

http://codereview.appspot.com/135052/diff/1/7#newcode74
Line 74: // thrown.
On 2009/10/20 01:40:37, DavidSarah wrote:
> Also, "eval" and "arguments" (see http://bugs.ecmascript.org/ticket/467 ) are
> not allowed as identifiers in ES5 strict mode.

I meant, not allowed as LeftHandSideExpressions (and the simplest way to avoid
that is to avoid them as identifiers).